Design follow-ups: On Call hospital change in the hero, square Clinical chips, readable small labels

Merged
BI
1mo ago
+537-54

User description

Summary

Before: On Call named the hospital twice, once in the summary card and again on a line below that held the Change button. Some Clinical chips (the search prompt chips and the "Show all" chip) were rounded pills, a Work-mode shape. Small labels on the CPD and Admin heroes, the My Day ring legend and the Roster legend were faint or 10 px. Admin had no date line over its title. Favourites could split a drug name mid-word ("Acamprosa te"). The safety plan's step counts looked like empty boxes to type into. The Work search "New" note could sit over CPD's Customise button until dismissed.

After: On Call's hero carries a quiet "Change hospital" pill, and the duplicate hospital line is gone. Clinical chips use the Clinical square-ish corners, and Work keeps its pills. Hero and legend labels are 12 px at full contrast. Admin shows the date line like every other Work page. Favourites names wrap only at spaces and end in an ellipsis. Safety plan counts are a quiet tinted number that a screen reader hears as "3 entries". The Work search note shows once per device and goes by itself after 8 seconds, or at the first tap, key or scroll.

These are the agreed follow-ups from the 15 Oct 2026 design critique. Presentation only, with no clinical content, data, auth or provider changes. Josh saw the before and after picture and approved it on 16 Oct 2026.

Areas touched: Personal practice, App experience, Answer engine

RAG impact: no retrieval behaviour change. answer-suggestion-chips.tsx gains a corner-shape option only. No ranking, retrieval or ordering file was touched.

Verification

  • Checks run:
    • Typecheck: TSC_EXIT 0. ESLint clean on every changed file. Prettier: "All matched files use Prettier code style!"
    • npm run test:focused on all 22 changed files: "Test Files 112 passed (112)", "Tests 1419 passed (1419)".
    • Browser suites left to CI.

Risk and rollout

  • Risk: low. Styling and small component props only.
  • Rollback: revert the single commit.
  • Provider or production effects: None.

Notes

  • The branch was rebuilt on main after PR 3559 merged. The On Call signed-out and roster-error wording and the phone focus fix from 3559 are kept.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw

CodeAnt-AI Description

Improve clarity across On Call, Clinical tools, and Work pages

What Changed

  • On Call names the hospital once in the hero and places “Change hospital” beside the call action when multiple hospitals are available.
  • Clinical chips use square-ish corners while Work prompt chips keep their pill shape; Medicines suggestions follow the Clinical style.
  • Admin shows the date above its title, and small labels across CPD, My Day, and Roster are easier to read.
  • Favourite names no longer split mid-word, and safety-plan counts look like counts and are announced with their labels.
  • The Work search “New” note clears after 8 seconds or when the reader interacts elsewhere, and does not return once shown.

Impact

✅ Hospital changes without duplicate hospital names
✅ Easier-to-read Work page labels
✅ Favourite names stay intact
✅ Search tip clears the page automatically

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • New Features

    • Added a “Change hospital” action to the on-call hero when multiple hospitals are available.
    • Added clearer entry and reason counts to patient safety plans, including accessible count labels.
    • Added optional control-shaped suggestion chips for Clinical prompts.

  • Style

    • Improved text legibility in roster and shift legends, favourite names, and selected hero labels.
    • Updated corner shapes for Clinical controls and medicine search suggestions.

  • Bug Fixes

    • Refined the timing and dismissal behavior of the Work Search “New” note.
    • Kept the Admin Today date visible in the mode heading.