chore: bump the MSRV pin to Rust 1.99.0

Merged
RM
4d ago
+144-46

User description

Closes #98

Summary

  • Bump the minimum Rust version from 1.98.1 to 1.99.0 at every live pin: Cargo.toml rust-version, rust-toolchain.toml, every CI toolchain: value, .github/scripts/qualify-package.py, Dockerfile, .devin/blueprint.yaml, and the docs that name the pin (README.md, REVIEW.md, AGENTS.md, docs/ci.md, CLAUDE.md).
  • Rust 1.99 deprecates AtomicU64::fetch_update. The test clock in src/health/clock.rs calls try_update so clippy -D warnings stays clean. Saturating advance behavior is unchanged.
  • Static libzmq from zeromq-src 0.2.6 mallocs yqueue chunks while command_t is 64-byte aligned. Ubuntu 26.04's x86-64-v3 GCC copies that type with vmovdqa and SIGSEGVs. .cargo/config.toml passes HAVE_POSIX_MEMALIGN and a 64-byte cache line as per-triple CFLAGS / CXXFLAGS for Linux and macOS. The cc crate appends those to caller flags. Windows is omitted. cargo install loads that packaged config; an external crate that depends on this package must set the same defines itself.
  • Checkpoint fixture cleanup ignores only a missing directory. The usefulness report records that reproduction now uses Rust 1.99.0 while the committed results stay on the 1.98.1 run.

crates.io corpus-ipc 0.1.0 still declares Rust 1.98.1. corpus-ipc on main, axon-encoder, and synaptic-wiring are already 1.99.0 (Limen-Neural/corpus-ipc#57 is merged). This compiler accepts the published crate, so the build does not pass --ignore-rust-version.

Test plan

  • cargo fmt --check on Rust 1.99.0
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo test --locked --lib checkpoint:: (21 passed)
  • cargo package --locked --list includes .cargo/config.toml
  • CC=gcc CXX=g++ cargo clippy --locked --all-targets --all-features -- -D warnings (previous head)
  • CC=gcc CXX=g++ cargo test --locked --all-features (previous head: 182 unit tests passed, 1 ignored, plus config_startup, pub_lifecycle, thalamic_brainstem_smoke)
Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by cubic

Bumps the minimum supported Rust version from 1.98.1 to 1.99.0 at every pinned location: Cargo.toml, rust-toolchain.toml, CI workflows, the package qualification script, Dockerfile, .devin/blueprint.yaml, and the docs that name the pin. Building the crate, including from crates.io, now requires 1.99.0; a 1.98.x toolchain is rejected. Closes #98.

  • Rust 1.99 deprecates AtomicU64::fetch_update; the test clock in src/health/clock.rs now uses try_update, keeping clippy -D warnings clean with unchanged saturating behavior.
  • On Ubuntu 26.04, static libzmq from zeromq-src 0.2.6 misaligns 64-byte command_t slots under x86-64-v3 GCC; .cargo/config.toml and the qualification script set HAVE_POSIX_MEMALIGN with a 64-byte cache line as per-triple compiler flags so caller CFLAGS stay intact, and the corpus-ipc CI cache key is bumped to v2. Only the named Unix triples get these defines; Windows is left alone, and external crates depending on this package must set the same defines themselves.
  • The corpus-ipc test binary is linked with the system linker, but CI still captures a gdb backtrace when it dies with signal 11. crates.io corpus-ipc 0.1.0 declares Rust 1.98.1, which this toolchain accepts, so builds do not need --ignore-rust-version.
  • The usefulness runner targets 1.99.0 while committed result files stay on the 1.98.1 run that produced them. Checkpoint tests clear stale fixture directories from a restored target/ cache.

CodeAnt-AI Description

Require Rust 1.99 and prevent ZeroMQ crashes in corpus-ipc builds

What Changed

  • Building the daemon now requires Rust 1.99.0; Rust 1.98.x is rejected. Repository tools and build instructions use the same version.
  • corpus-ipc builds apply alignment settings on supported Unix targets, preventing a ZeroMQ crash with Ubuntu 26.04 and x86-64-v3 GCC. External projects that depend on the daemon must apply the documented settings themselves.

Impact

✅ Consistent Rust 1.99.0 build requirements
✅ Fewer corpus-ipc crashes on Ubuntu 26.04
✅ Clear setup instructions for external corpus-ipc builds

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.