Upgrade Rust to 1.99.0 and clean Cargo package exclusions
User description
What / why
Rust pin audit: the repo is already on 1.99.0 everywhere, so no toolchain pin changed. Verified sites:
| Site | Value |
|---|---|
Cargo.toml rust-version | 1.99.0 |
rust-toolchain.toml channel | 1.99.0 |
.github/workflows/ci.yml toolchain: (4 jobs: fmt, stub, corpus-ipc, package) | 1.99.0 |
.github/scripts/qualify-package.py cargo +1.99.0 / rustc +1.99.0 | 1.99.0 |
Dockerfile FROM rust:1.99.0-bookworm | 1.99.0 |
.devin/blueprint.yaml rustup install/default | 1.99.0 |
README.md, AGENTS.md, CLAUDE.md, REVIEW.md, docs/ci.md, experiments/usefulness/run.sh | 1.99.0 |
No .devcontainer/ or .cursor/ directory exists. The only remaining 1.98.1 strings are in committed experiments/usefulness/results/* and REPORT.md, which intentionally record the historical run that produced them (REPORT.md says so explicitly).
Package exclusion cleanup (cargo package --list --allow-dirty): the crate was shipping
.agents/setup(Cursor Cloud bootstrap script: apt-get + rustup), and- ~1.9 MiB of experiment result artifacts under
experiments/usefulness/results/(per-run logs,.jsonl.gztraces, summaries).
Both are now in [package] exclude, and REPOSITORY_ONLY in qualify-package.py rejects them so the CI package job fails if they come back. Kept in the package: experiments/usefulness/{PROTOCOL.md,REPORT.md,run.sh,summarize.py,config/,fixtures/} (the usefulness_* examples read those fixtures), .cargo/config.toml (the extracted package needs its libzmq alignment defines; see the comment in qualify-package.py), Cargo.lock (binary crate; --locked is the documented workflow), both licenses, README.md, rust-toolchain.toml.
Package list: 62 files after this change; zero .agents/ or results/ entries.
How verified (Rust 1.99.0, Linux, CPU only)
cargo fmt --check— cleancargo clippy --locked --all-targets -- -D warnings— cleancargo test --locked— 159 passed, 1 ignored;config_startuppassedRUSTDOCFLAGS="-D warnings" cargo doc --locked --no-deps— cleanCC=gcc CXX=g++ cargo clippy --locked --all-targets --all-features -- -D warnings— clean (libzmq built from source)CC=gcc CXX=g++ cargo test --locked --all-features— 182 passed, 1 ignored;config_startup,thalamic_brainstem_smoke,pub_lifecyclepassedpython3 -m py_compile .github/scripts/qualify-package.py— ok (fullqualify-package.pynot run locally; it needs a clean committed checkout and runs a publish dry-run; the CIpackagejob covers it)
Acceptance checklist
- Every Rust pin site audited and on 1.99.0 (no change needed)
-
[package] excludeaudited viacargo package --list; agent/CI/devin files and bulky result artifacts excluded; license/README/fixtures included - Package qualification gate updated to enforce the new exclusions
- fmt, clippy
-D warnings, tests (stub +--all-features), rustdoc-D warningsgreen on 1.99.0 - CI
packagejob (publish dry-run) — runs in GitHub Actions on this PR
Out of scope: publishing, consumer bumps, edition/API changes.
Closes LIM-1514
Generated by Claude Code
<source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v3.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v3-3x.png" width="162" height="28">https://backend.blacksmith.sh/track/enable-autofix?expires=1795522358&installation_model_id=442967&pr_number=104&ref=codesmith_pr_footer&repository=Limen-Neural%2Fbrainstem-daemon&return_to=https%3A%2F%2Fgithub.com%2FLimen-Neural%2Fbrainstem-daemon%2Fpull%2F104&signature=f00005541ba8127f0cbc07cbe7e7a193512e646bcc00cdcaba2a8572c32a27dd"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png" width="190" height="28">
Need help on this PR? Tag @codesmith-bot with what you need.
Generated by Claude Code
CodeAnt-AI Description
Exclude setup scripts and experiment results from published crates
What Changed
- Published crates no longer include the repository setup script or committed experiment results.
- Package checks now reject those files if they are included again.
- The experiment report links to the results on GitHub instead of expecting them in the crate.
Impact
✅ Smaller crate downloads
✅ No repository setup script in published crates
✅ Experiment results remain accessible on GitHub
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
@codeant-ai ask: Your question here
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
@codeant-ai ask: Can you suggest a safer alternative to storing this secret?
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
@codeant-ai: Your feedback here
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
@codeant-ai: Do not flag unused imports.
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
@codeant-ai: review
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.