Allow strings as dates in typescript-node generator to fix error: data.toISOString() is not a function

Merged
AD
17d ago
+15-0

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

I was having a problem with data generated from an untyped endpoint being passed into an endpoint that did have a date type for a field.

    TypeError: data.toISOString is not a function

      491 |             return transformedData;
      492 |         } else if (type === "Date") {
    > 493 |             return data.toISOString();
          |                         ^
      494 |         } else {
      495 |             if (enumsMap[type]) {
      496 |                 return data;

      at Function.serialize (../openapi/model/models.ts:493:25)
      at Function.serialize (../openapi/model/models.ts:510:69)
      at Function.serialize (../openapi/model/models.ts:510:69)
      at Function.serialize (../openapi/model/models.ts:510:69)

The fix coerces the string into a date before getting the ISO string to ensure uniformity. I'm open to just passing along the string as is too, but throwing on reasonably valid input doesn't make sense.