fix(go-server): avoid AssertstringRequired for primitive-typed models
HA
1mo ago+112+112+012345678901234567890123456789-0-0-0123456789
oneOf/nullable enums can flatten to string while still flagged as models, so templates must not emit Assertstring helpers that do not exist.
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Stops Go server codegen from emitting Assertstring* calls when composed schemas flatten to Go primitives (e.g., nullable oneOf enums), preventing bad references and compile errors. Primitive detection is centralized in AbstractGoCodegen so all Go generators treat these as primitives.
- Bug Fixes
- Clear
isModeland setisPrimitiveTypeinAbstractGoCodegen.fromPropertywhen the Go type (incl. pointer types) is primitive; applies to array items too. - Add missing Go builtins to
languageSpecificPrimitives:uint8,uint16,int8,int16,uintptr, and update Go generator docs to list them. - Tests and sample spec verify no
AssertstringRequired/Constraintsgeneration andAssertThingRequiredis a no-op.
- Clear