fix(typescript-...): Fix basic auth without username or password
CO
8h ago+13+13+01234567890123456789-13-13-01234567890123456789
Missing password or username in multiple typescript generators concat the undefined to the string resulting in a invalid auth header.
typescript-inversify also misses a 'Basic ' prefix
PR checklist
- Read the contribution guidelines.
- Run the following to build the project and update samples:
(For Windows users, please run the script in WSL)./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*.
IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Summary by cubic
Fixes basic auth in TypeScript and JavaScript generators so a missing username or password no longer produces an invalid Authorization header, and restores the missing Basic prefix in the typescript-inversify generator.
- Defaults missing username or password values to empty strings instead of concatenating
undefined. - Updates
Javascript-Apollo,Javascript-Flowtyped, theJavascriptapollo library,typescript-angular,typescript-fetch,typescript-inversify,typescript-jquery,typescript-nestjs, andtypescript-playwrighttemplates, and regenerates affected samples.