**Actionable comments posted: 1**

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Inline comments: In `@apps/meteor/app/api/server/v1/chat.ts`: - Around line 277-304: The schema ChatGetDiscussionsSchema is missing the optional 'sort' property while the type ChatGetDiscussions and the handler expect it, causing requests with ?sort=... to be rejected; update ChatGetDiscussionsSchema by adding a 'sort' entry under properties (e.g., type: 'string') and keep additionalProperties: false so valid sort query strings are accepted by the validator. ```

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR: - [ ] Push a commit to this branch (recommended) - [ ] Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `0f20afde-4b52-40cc-a998-b11d8c00c19b`

📥 Commits

Reviewing files that changed from the base of the PR and between a834e1707691413778cb74f379328929979541f1 and 977f3ef206cb4dba3f09a49d8f2f0e35ca9ddb62.

📒 Files selected for processing (3)

* `.changeset/migrate-chat-getDiscussions-to-openapi.md` * `apps/meteor/app/api/server/v1/chat.ts` * `packages/rest-typings/src/v1/chat.ts`

💤 Files with no reviewable changes (1)

* packages/rest-typings/src/v1/chat.ts

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

* GitHub Check: cubic · AI code reviewer

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

**📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)** > `**/*.{ts,tsx,js}`: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests > Avoid code comments in the implementation Files: - `apps/meteor/app/api/server/v1/chat.ts`

🧠 Learnings (16)

📓 Common learnings

``` Learnt from: smirk-dev Repo: RocketChat/Rocket.Chat PR: 39625 File: apps/meteor/app/api/server/v1/push.ts:85-97 Timestamp: 2026-03-14T14:58:50.283Z Learning: In RocketChat/Rocket.Chat, the `push.token` POST/DELETE endpoints in `apps/meteor/app/api/server/v1/push.ts` were already migrated to the chained router API pattern on `develop` prior to PR `#39625`. `cleanTokenResult` (which strips `authToken` and returns `PushTokenResult`) and `isPushTokenPOSTProps`/`isPushTokenDELETEProps` validators already exist on `develop`. PR `#39625` only migrates `push.get` and `push.info` to the chained pattern. Do not flag `cleanTokenResult` or `PushTokenResult` as newly introduced behavior-breaking changes when reviewing this PR. ``` ``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39414 File: apps/meteor/app/api/server/v1/rooms.ts:1241-1297 Timestamp: 2026-03-10T08:13:52.153Z Learning: In the RocketChat/Rocket.Chat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1/rooms.ts, the pattern `ajv.compile({...})` is intentionally used for the 200 response schema even when the endpoint returns `{ success: true }`. This is an established convention across all migrated endpoints (rooms.leave, rooms.favorite, rooms.delete, rooms.muteUser, rooms.unmuteUser). Do not flag this as a type mismatch during reviews of these migration PRs. ``` ``` Learnt from: amitb0ra Repo: RocketChat/Rocket.Chat PR: 39647 File: apps/meteor/app/api/server/v1/users.ts:710-757 Timestamp: 2026-03-15T14:31:25.380Z Learning: In RocketChat/Rocket.Chat, the `UserCreateParamsPOST` type in `apps/meteor/app/api/server/v1/users.ts` (migrated from `packages/rest-typings/src/v1/users/UserCreateParamsPOST.ts`) intentionally has `fields: string` (non-optional) and `settings?: IUserSettings` without a corresponding AJV schema entry. This is a pre-existing divergence carried over verbatim from the original rest-typings source (PR `#39647`). Do not flag this type/schema misalignment during the OpenAPI migration review — it is tracked as a separate follow-up fix. ``` ``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 38974 File: apps/meteor/app/api/server/v1/im.ts:220-221 Timestamp: 2026-02-24T19:09:09.561Z Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight. ``` ``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39230 File: apps/meteor/app/api/server/v1/chat.ts:214-222 Timestamp: 2026-03-03T11:11:48.541Z Learning: In apps/meteor/server/lib/moderation/reportMessage.ts, the reportMessage function validates that description is not empty or whitespace-only with `if (!description.trim())`. When migrating the chat.reportMessage endpoint to OpenAPI, adding minLength validation to the schema preserves this existing behavior. ``` ``` Learnt from: ggazzo Repo: RocketChat/Rocket.Chat PR: 35995 File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112 Timestamp: 2026-02-23T17:53:18.785Z Learning: In Rocket.Chat PR reviews, maintain strict scope boundaries—when a PR is focused on a specific endpoint (e.g., rooms.favorite), avoid reviewing or suggesting changes to other endpoints that were incidentally refactored (e.g., rooms.invite) unless explicitly requested by maintainers. ``` ``` Learnt from: amitb0ra Repo: RocketChat/Rocket.Chat PR: 39647 File: apps/meteor/app/api/server/v1/users.ts:891-899 Timestamp: 2026-03-15T14:31:18.012Z Learning: In RocketChat/Rocket.Chat, `IUser.inactiveReason` in `packages/core-typings/src/IUser.ts` is typed as `'deactivated' | 'pending_approval' | 'idle_too_long'` (optional, no `null`), but the database stores `null` for newly created users. The Typia-generated `$ref: '#/components/schemas/IUser'` schema therefore correctly rejects `null` for `inactiveReason`. This causes the test "should create a new user with default roles" to fail when response validation is active (TEST_MODE). The fix is to add `| null` to `inactiveReason` in core-typings and rebuild Typia schemas in a separate PR. Do not flag this test failure as a bug introduced by the users.create OpenAPI migration (PR `#39647`). Do not suggest inlining a custom schema to work around it, as migration rules require using `$ref` when a Typia schema exists. ``` ``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 38913 File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34 Timestamp: 2026-02-25T20:10:16.987Z Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out. ``` ``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39340 File: apps/meteor/app/api/server/v1/im.ts:1349-1398 Timestamp: 2026-03-12T10:26:26.697Z Learning: In `apps/meteor/app/api/server/v1/im.ts` (PR `#39340`), the `DmEndpoints` type intentionally includes temporary stub entries for `/v1/im.kick`, `/v1/dm.kick`, `/v1/im.leave`, and `/v1/dm.leave` (using `DmKickProps` and `DmLeaveProps`) even though no route handlers exist for them yet. These stubs were added to preserve type compatibility after removing the original `DmLeaveProps` and related files. They are planned for cleanup in a follow-up PR. Do not flag these as missing implementations when reviewing this file until the follow-up is merged. ```

📚 Learning: 2026-02-24T19:09:09.561Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 38974 File: apps/meteor/app/api/server/v1/im.ts:220-221 Timestamp: 2026-02-24T19:09:09.561Z Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md`

📚 Learning: 2026-03-15T14:31:25.380Z

``` Learnt from: amitb0ra Repo: RocketChat/Rocket.Chat PR: 39647 File: apps/meteor/app/api/server/v1/users.ts:710-757 Timestamp: 2026-03-15T14:31:25.380Z Learning: In RocketChat/Rocket.Chat, the `UserCreateParamsPOST` type in `apps/meteor/app/api/server/v1/users.ts` (migrated from `packages/rest-typings/src/v1/users/UserCreateParamsPOST.ts`) intentionally has `fields: string` (non-optional) and `settings?: IUserSettings` without a corresponding AJV schema entry. This is a pre-existing divergence carried over verbatim from the original rest-typings source (PR `#39647`). Do not flag this type/schema misalignment during the OpenAPI migration review — it is tracked as a separate follow-up fix. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md` - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-02-25T20:10:16.987Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 38913 File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34 Timestamp: 2026-02-25T20:10:16.987Z Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md` - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-03-14T14:58:50.283Z

📚 Learning: 2026-03-10T08:13:52.153Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39414 File: apps/meteor/app/api/server/v1/rooms.ts:1241-1297 Timestamp: 2026-03-10T08:13:52.153Z Learning: In the RocketChat/Rocket.Chat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1/rooms.ts, the pattern `ajv.compile({...})` is intentionally used for the 200 response schema even when the endpoint returns `{ success: true }`. This is an established convention across all migrated endpoints (rooms.leave, rooms.favorite, rooms.delete, rooms.muteUser, rooms.unmuteUser). Do not flag this as a type mismatch during reviews of these migration PRs. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md` - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-03-03T11:11:48.541Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39230 File: apps/meteor/app/api/server/v1/chat.ts:214-222 Timestamp: 2026-03-03T11:11:48.541Z Learning: In apps/meteor/server/lib/moderation/reportMessage.ts, the reportMessage function validates that description is not empty or whitespace-only with `if (!description.trim())`. When migrating the chat.reportMessage endpoint to OpenAPI, adding minLength validation to the schema preserves this existing behavior. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md`

📚 Learning: 2026-02-24T19:05:56.710Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 0 File: :0-0 Timestamp: 2026-02-24T19:05:56.710Z Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md`

📚 Learning: 2026-02-10T16:32:49.806Z

``` Learnt from: tassoevan Repo: RocketChat/Rocket.Chat PR: 38528 File: apps/meteor/client/startup/roles.ts:14-14 Timestamp: 2026-02-10T16:32:49.806Z Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON which automatically deserializes Date objects. Stream handlers (e.g., sdk.stream()) receive Date fields as Date objects directly and do not require manual conversion using `new Date()`. Only REST API responses require manual date conversion because they return plain JSON where dates are serialized as strings. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md`

📚 Learning: 2025-10-28T16:53:42.761Z

``` Learnt from: ricardogarim Repo: RocketChat/Rocket.Chat PR: 37205 File: ee/packages/federation-matrix/src/FederationMatrix.ts:296-301 Timestamp: 2025-10-28T16:53:42.761Z Learning: In the Rocket.Chat federation-matrix integration (ee/packages/federation-matrix/), the createRoom method from rocket.chat/federation-sdk will support a 4-argument signature (userId, roomName, visibility, displayName) in newer versions. Code using this 4-argument call is forward-compatible with planned library updates and should not be flagged as an error. ``` **Applied to files:** - `.changeset/migrate-chat-getDiscussions-to-openapi.md` - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-02-24T19:09:01.522Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 38974 File: apps/meteor/app/api/server/v1/im.ts:220-221 Timestamp: 2026-02-24T19:09:01.522Z Learning: In Rocket.Chat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1, avoid introducing logic changes. Only perform scope-tight changes that preserve behavior; style-only cleanups (e.g., removing inline comments) may be deferred to follow-ups to keep the migration PR focused. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-03-12T10:26:26.697Z

``` Learnt from: ahmed-n-abdeltwab Repo: RocketChat/Rocket.Chat PR: 39340 File: apps/meteor/app/api/server/v1/im.ts:1349-1398 Timestamp: 2026-03-12T10:26:26.697Z Learning: In `apps/meteor/app/api/server/v1/im.ts` (PR `#39340`), the `DmEndpoints` type intentionally includes temporary stub entries for `/v1/im.kick`, `/v1/dm.kick`, `/v1/im.leave`, and `/v1/dm.leave` (using `DmKickProps` and `DmLeaveProps`) even though no route handlers exist for them yet. These stubs were added to preserve type compatibility after removing the original `DmLeaveProps` and related files. They are planned for cleanup in a follow-up PR. Do not flag these as missing implementations when reviewing this file until the follow-up is merged. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-02-23T17:53:06.802Z

``` Learnt from: ggazzo Repo: RocketChat/Rocket.Chat PR: 35995 File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112 Timestamp: 2026-02-23T17:53:06.802Z Learning: During PR reviews that touch endpoint files under apps/meteor/app/api/server/v1, enforce strict scope: if a PR targets a specific endpoint (e.g., rooms.favorite), do not propose changes to unrelated endpoints (e.g., rooms.invite) unless maintainers explicitly request them. Focus feedback on the touched endpoint's behavior, API surface, and related tests; avoid broad cross-endpoint changes in the same PR unless requested. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-03-11T22:04:20.529Z

``` Learnt from: juliajforesti Repo: RocketChat/Rocket.Chat PR: 39545 File: apps/meteor/client/views/room/body/hooks/useHasNewMessages.ts:59-61 Timestamp: 2026-03-11T22:04:20.529Z Learning: In `apps/meteor/client/views/room/body/hooks/useHasNewMessages.ts`, the `msg.u._id === uid` early-return in the `streamNewMessage` handler is intentional: the "New messages" indicator is designed to notify about messages from other users only. Self-sent messages — including those sent from a different session/device — are always skipped, by design. Do not flag this as a multi-session regression. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-02-26T19:25:44.063Z

``` Learnt from: gabriellsh Repo: RocketChat/Rocket.Chat PR: 38778 File: packages/ui-voip/src/providers/useMediaSession.ts:192-192 Timestamp: 2026-02-26T19:25:44.063Z Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

📚 Learning: 2026-02-26T19:25:44.063Z

``` Learnt from: gabriellsh Repo: RocketChat/Rocket.Chat PR: 38778 File: packages/ui-voip/src/providers/useMediaSession.ts:192-192 Timestamp: 2026-02-26T19:25:44.063Z Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead. ``` **Applied to files:** - `apps/meteor/app/api/server/v1/chat.ts`

🔇 Additional comments (2)

apps/meteor/app/api/server/v1/chat.ts (1)
`2-2`: **Import update looks correct.** `IRoom` is used by the new `ChatGetDiscussions` typing and the import is scoped as type-only.

.changeset/migrate-chat-getDiscussions-to-openapi.md (1)
`1-6`: **Changeset entry is aligned with the migration scope.** Version bumps and summary text are consistent with the endpoint migration.