**Actionable comments posted: 1**

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Inline comments: In `@apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`: - Around line 87-91: The image can overflow its aspect-ratio container because only width is constrained; update the inline style in AttachmentImage (the element with style { maxWidth:'100%', height:'auto', objectFit:'contain' }) to constrain height as well so object-fit: 'contain' takes effect — e.g., replace height:'auto' with height:'100%' (or add maxHeight:'100%') so portrait images cannot spill out of the parent ImageBox/aspect-ratio wrapper; ensure the change is applied where the image element is rendered in AttachmentImage.tsx. ```

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR: - [ ] Push a commit to this branch (recommended) - [ ] Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `9c95aacf-a0f3-45e6-9f9a-a2000224ad6f`

📥 Commits

Reviewing files that changed from the base of the PR and between ceefff9dbedc8d62d6e6863d0a74ee8ddc2517dc and b50d6af2d6881411d2cfad5a51c4b0465b13d9e2.

📒 Files selected for processing (1)

* `apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`

📜 Review details

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

**📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)** > `**/*.{ts,tsx,js}`: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests > Avoid code comments in the implementation Files: - `apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`

🧠 Learnings (4)

📓 Common learnings

``` Learnt from: ggazzo Repo: RocketChat/Rocket.Chat PR: 35995 File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112 Timestamp: 2026-02-23T17:53:18.785Z Learning: In Rocket.Chat PR reviews, maintain strict scope boundaries—when a PR is focused on a specific endpoint (e.g., rooms.favorite), avoid reviewing or suggesting changes to other endpoints that were incidentally refactored (e.g., rooms.invite) unless explicitly requested by maintainers. ```

📚 Learning: 2026-04-10T22:42:05.539Z

``` Learnt from: dougfabris Repo: RocketChat/Rocket.Chat PR: 40075 File: apps/meteor/client/views/room/modals/FileUploadModal/FileUploadModal.tsx:69-71 Timestamp: 2026-04-10T22:42:05.539Z Learning: In `apps/meteor/client/views/room/modals/FileUploadModal/FileUploadModal.tsx`, the submit handler converts an empty/whitespace-only description to `undefined` (`description?.trim() || undefined`) intentionally. All downstream image-rendering components (`AttachmentImage`, `ImagePreview`, `ImageItem`, `ImageGallery`) default `undefined` alt to `''`, so the `` attribute is always present. Do not flag this `undefined` conversion as a bug preventing alt text from being cleared. ``` **Applied to files:** - `apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`

📚 Learning: 2026-04-17T23:32:07.223Z

``` Learnt from: d-gubert Repo: RocketChat/Rocket.Chat PR: 38357 File: apps/meteor/app/apps/server/converters/messages.ts:348-352 Timestamp: 2026-04-17T23:32:07.223Z Learning: In `apps/meteor/app/apps/server/converters/messages.ts`, the `timestamp` handler inside `_convertAttachmentsToApp` uses a non-null assertion (`attachment.ts!`) intentionally. The `ts` property on `MessageAttachment` is optional only to accommodate MessageAttachment creation-time scenarios; by the time `_convertAttachmentsToApp` is called, the message has already been stored and the attachment is guaranteed to have a `ts` value. Do not flag this non-null assertion as unsafe during code review. ``` **Applied to files:** - `apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`

📚 Learning: 2026-03-27T14:52:56.865Z

``` Learnt from: dougfabris Repo: RocketChat/Rocket.Chat PR: 39892 File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155 Timestamp: 2026-03-27T14:52:56.865Z Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported. ``` **Applied to files:** - `apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx`

🔇 Additional comments (1)

apps/meteor/client/components/message/content/attachments/structure/AttachmentImage.tsx (1)
`82-93`: _⚠️ Potential issue_ | _🟡 Minor_ **Inconsistent indentation on `` attributes — uses spaces instead of tabs.** The `` opening tag uses tabs (consistent with surrounding JSX), but all its attributes use 2 spaces. Re-indent the attributes with tabs to match the file's indentation style.

⛔ Skipped due to learnings
``` Learnt from: dougfabris Repo: RocketChat/Rocket.Chat PR: 40075 File: apps/meteor/client/views/room/modals/FileUploadModal/FileUploadModal.tsx:69-71 Timestamp: 2026-04-10T22:42:05.539Z Learning: In `apps/meteor/client/views/room/modals/FileUploadModal/FileUploadModal.tsx`, the submit handler converts an empty/whitespace-only description to `undefined` (`description?.trim() || undefined`) intentionally. All downstream image-rendering components (`AttachmentImage`, `ImagePreview`, `ImageItem`, `ImageGallery`) default `undefined` alt to `''`, so the `` attribute is always present. Do not flag this `undefined` conversion as a bug preventing alt text from being cleared. ```