chore: resolve lint warnings in ten packages

Merged
KE
14h ago
+28-29

Proposed changes (including videos or screenshots)

Resolve 15 oxlint warnings across ten packages and remove their remaining TypeScript suppression directives. Commits are scoped to individual packages:

  • base64: type the numeric character lookup table.
  • instance-status: use optional chaining when checking the TTL index.
  • media-signaling: narrow parsed data-channel commands before returning them.
  • model-typings: replace the empty Smarsh history model interface with an equivalent type alias.
  • omni-core-ee: use MongoDB document filter types for department restrictions and remove the redundant argument to countUnits().
  • cas-validate: scope declarations inside the RubyCAS switch default branch.
  • cron: type internal job results as unknown.
  • server-fetch: remove a redundant assertion, use Node’s built-in AbortController, and align request option types with node-fetch.
  • jest-presets: remove unnecessary assertions from the IntersectionObserver and TextEncoder mocks.
  • logo: assert that both logo components render a labelled SVG.

Issue(s)

JIRA

Steps to test or reproduce

Verified locally:

  • Each changed package passes lint with --max-warnings 0 and TypeScript with --noEmit.
  • base64: all 9 tests pass.
  • media-signaling: all 69 tests pass.
  • omni-core-ee: all 41 tests pass.
  • cas-validate: all 5 tests pass.
  • server-fetch: all 107 tests pass, including cancellation and connection cleanup.
  • logo: both tests pass against the rebuilt client Jest preset.
  • jest-presets builds successfully.
  • model-typings and its models consumer compile, including declaration generation.
  • server-fetch builds and its ABAC consumer passes typechecking.
  • Source scan: zero lint or TypeScript suppression directives across all ten packages.
  • Root yarn lint: 98 successful tasks, zero errors.

Further comments

The root lint run still reports 4,978 existing source warnings in other packages. A full Meteor build was not run.

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of malformed WebRTC messages by accepting commands only when they are strings and pass validation.
  • Refactor
    • Updated internal type handling and checks across several areas, including request and department query types. Most runtime behavior remains unchanged.
  • Tests
    • Strengthened logo checks to verify that the rendered logo is an SVG with an accessible label.