**Actionable comments posted: 8**

🧹 Nitpick comments (2)

packages/mongodb/package.json (1)
`51-51`: **Replace fixed startup sleep with health-based readiness wait.** Line 51 uses a hardcoded delay, which is prone to flaky startup on slower runners.

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@packages/mongodb/package.json` at line 51, The package.json script "test:integration:setup" currently uses a fixed "sleep 10" which is flaky; replace that sleep with a health-based readiness wait (either call an existing wait-for utility or add a small script that polls container health/status) so the command becomes: bring up compose with "docker compose -f docker-compose.test.yaml up -d" and then block until the target service(s) report healthy (poll via "docker compose ps" health status or TCP probe) before exiting; update the "test:integration:setup" script to invoke that health-wait mechanism instead of sleep. ```

packages/mongodb/src/index.integration.test.ts (1)
`32-45`: **Ensure MongoClient is always closed in cleanup path.** If collection cleanup throws, Line 44 is skipped and the client can leak across tests. Wrap cleanup in `try/finally`.

Suggested change
```diff const { MongoClient } = await import("mongodb"); const client = new MongoClient(MONGO_URI); - await client.connect(); - const db = client.db(TEST_DATABASE); - - const collections = await db.listCollections().toArray(); - for (const collection of collections) { - if (collection.name.startsWith("test_memory_")) { - await db.collection(collection.name).deleteMany({}); - } - } - - await client.close(); + try { + await client.connect(); + const db = client.db(TEST_DATABASE); + + const collections = await db.listCollections().toArray(); + for (const collection of collections) { + if (collection.name.startsWith("test_memory_")) { + await db.collection(collection.name).deleteMany({}); + } + } + } finally { + await client.close(); + } ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@packages/mongodb/src/index.integration.test.ts` around lines 32 - 45, The cleanup loop that lists collections and calls db.collection(...).deleteMany(...) can throw and currently may skip client.close(), so wrap the collection cleanup in a try/finally around the MongoClient lifecycle: after creating and connecting the MongoClient (MongoClient, client.connect(), MONGO_URI, TEST_DATABASE, db.listCollections()), perform the deletion logic inside a try block and call client.close() in the finally block to guarantee the client is always closed even if deleteMany or listCollections throws. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Inline comments: In `@packages/mongodb/docker-compose.test.yaml`: - Around line 4-7: The docker-compose test file hardcodes container_name and host port mapping (container_name: 'voltagent-mongodb-test' and ports: - '27017:27017'), causing global collisions in concurrent/local CI runs; remove the fixed container_name and avoid binding the container port to the host by either deleting the container_name line and changing ports to expose only the container port (e.g., "27017" or no host mapping) or make the host port configurable using an env var (e.g., replace '27017:27017' with "${MONGO_PORT:-27017}:27017" or use project-scoped names like "${COMPOSE_PROJECT_NAME:-voltagent}-mongodb-test") so tests can run in parallel without collisions. In `@packages/mongodb/package.json`: - Around line 49-53: The integration script currently uses "&&" so test:integration:teardown only runs on successful tests; change test:integration to run test:integration:setup, run the vitest command inside a shell that captures its exit code, always runs npm run test:integration:teardown, then exits with the original vitest code. Update the "test:integration" script (referencing test:integration, test:integration:setup, and test:integration:teardown) to wrap the vitest invocation so teardown always executes even when tests fail and the process returns the original test exit status. In `@packages/mongodb/src/index.integration.test.ts`: - Around line 26-28: Replace the fixed 1s sleep (the new Promise with setTimeout) with a deterministic wait for the component to be ready: remove the setTimeout-based wait and instead await a real readiness check — either call and await the module's exported initializer (e.g., initializeMongo or connectMongo) if available, or poll the Mongo client until a successful response (e.g., await client.connect() or loop until client.db().admin().ping() succeeds) with a short interval and timeout; update the test that contains the setTimeout promise to use that deterministic await so the test only proceeds when the DB is actually initialized. - Around line 390-404: Tests currently use the unsafe any type for test fixtures (e.g., the state object and conversation step arrays); import the proper types from `@voltagent/core` (WorkflowStateEntry and ConversationStepRecord) and annotate the test variables instead of any (or use the exported parameter types like Parameters[1] and Parameters[0][number] if you prefer). Update the declarations for the state fixture (previously typed as any) to WorkflowStateEntry and the conversation step fixtures to ConversationStepRecord, and add the corresponding import statements from `@voltagent/core` so the integration tests maintain compile-time type safety. In `@packages/mongodb/src/memory-adapter.spec.ts`: - Around line 56-58: Remove the unnecessary private method call: delete the explicit await (adapter as any).initialize() and instead rely on the constructor-triggered initialization (this.initPromise = this.initialize()) — either simply assert expect(MongoClient).toHaveBeenCalledTimes(1) after instantiation, or if you need to wait for completion, await the adapter's initialization promise (access via adapter.initPromise or adapter['initPromise']) before asserting; this preserves type safety and avoids casting to any. In `@packages/mongodb/src/memory-adapter.ts`: - Around line 203-207: Ensure we enforce conversation ownership before inserting messages: after fetching the conversation via this.getConversation(conversationId) (used in the insert message flow), verify that conversation.userId === userId and if not, throw a suitable error (e.g., ConversationNotFoundError or an AuthorizationError) to prevent cross-user writes; apply the same ownership check in the other analogous block around the second getConversation call (the one referenced at 244-248) so both insertion paths validate userId matches the conversation.userId before proceeding. - Around line 381-443: The code uses many `any` casts (e.g., getCollection("conversations"), insert/find results cast with `as any`, filter declarations typed `: any`, map callbacks `(item: any)`, and update result casts) which breaks TypeScript safety; replace these with concrete types imported from `@voltagent/core` and mongodb: use getCollection("conversations") (and analogous ConversationStepRecord, WorkflowStateEntry, etc.), use WithId or Document where appropriate for query results instead of `as any`, type filter objects as Partial or the exact filter shape, type map callbacks with the correct record type, and use mongodb types like UpdateResult for updates; ensure the necessary types are imported and remove all `any` casts so insertOne/findOne/countDocuments/updateOne usages and their mappings return properly typed values (e.g., in createConversation, countConversations, getConversation, update handlers, and workflow state queries). In `@website/docs/agents/memory/mongodb.md`: - Around line 41-57: Update the example to validate the required MONGODB_URI before constructing MongoDBMemoryAdapter: check process.env.MONGODB_URI (used in MongoDBMemoryAdapter) and throw or log a clear error if missing, or provide a brief inline comment noting it is required; ensure the validation happens prior to new Memory({ storage: new MongoDBMemoryAdapter(...) }) so Agent and Memory construction use a guaranteed non-null connection string. --- Nitpick comments: In `@packages/mongodb/package.json`: - Line 51: The package.json script "test:integration:setup" currently uses a fixed "sleep 10" which is flaky; replace that sleep with a health-based readiness wait (either call an existing wait-for utility or add a small script that polls container health/status) so the command becomes: bring up compose with "docker compose -f docker-compose.test.yaml up -d" and then block until the target service(s) report healthy (poll via "docker compose ps" health status or TCP probe) before exiting; update the "test:integration:setup" script to invoke that health-wait mechanism instead of sleep. In `@packages/mongodb/src/index.integration.test.ts`: - Around line 32-45: The cleanup loop that lists collections and calls db.collection(...).deleteMany(...) can throw and currently may skip client.close(), so wrap the collection cleanup in a try/finally around the MongoClient lifecycle: after creating and connecting the MongoClient (MongoClient, client.connect(), MONGO_URI, TEST_DATABASE, db.listCollections()), perform the deletion logic inside a try block and call client.close() in the finally block to guarantee the client is always closed even if deleteMany or listCollections throws. ```

---

ℹ️ Review info

**Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9751245819c330248b929a5d187dcf6c56b0c1e4 and 548468c6e57c040b546f19e017286607af9b2491.

⛔ Files ignored due to path filters (1)

* `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`

📒 Files selected for processing (17)

* `.changeset/mongodb-feature-storage.md` * `packages/mongodb/README.md` * `packages/mongodb/docker-compose.test.yaml` * `packages/mongodb/package.json` * `packages/mongodb/src/index.integration.test.ts` * `packages/mongodb/src/index.ts` * `packages/mongodb/src/memory-adapter.spec.ts` * `packages/mongodb/src/memory-adapter.ts` * `packages/mongodb/tsconfig.json` * `packages/mongodb/tsup.config.ts` * `packages/mongodb/vitest.config.mts` * `packages/mongodb/vitest.integration.config.mts` * `website/docs/agents/memory.md` * `website/docs/agents/memory/mongodb.md` * `website/docs/agents/memory/overview.md` * `website/sidebars.ts` * `website/static/llms.txt`