chore(ci): drop stale shared-header packaging, fallback, and nightly narrative

Merged
TH
11h ago
+15-46

Summary

Five hygiene deletions around the shared header landed by #3918, with no behavior change. 5 files.

  • scripts/size-report-package.mjs: assertPublishPackageContents rebuilt apple/macos-helper/Tests/<target>/PackStub.swift from the manifest three times; build expectedStubs once and derive both the missing list and its message from it (the take-or-leave note from the #3969 review). Both error messages keep their meaning.
  • scripts/package-apple-runner-source.mjs: delete the dist/apple/snapshot-bridge legacy entry. git log -S shows that mirror existed only on the #3918 branch iterations (581357bc72, d4032ed7f2, two checkpoints); git tag --contains 581357bc72 is empty, so no released package ever had it.
  • .github/workflows/xctest-nightly.yml: the iPad-leg comments described "the evidence line that probe prints", which the runner no longer prints; correct them to name the assertions. No steps, -only-testing: flags, or assertions change.
  • packages/platform-apple/src/runner/__tests__/runner-source.test.ts: delete the packaged-layout fingerprint duplicate. Production has no checkout/package branch for that header (runner-source.ts reads it at the same root-relative path in both layouts), so the two tests replayed one branch.
  • packages/platform-apple/src/snapshot-source/cache.ts: delete the dist/apple/snapshot-bridge packaged fallback in resolveSnapshotBridgeSourceRoot. It dates from #2277, before the package shipped apple/snapshot-bridge at its root; an installed package now resolves through the same root-relative path the checkout uses, and nothing writes the dist mirror anymore. One root check, same native-source-missing error.

Net āˆ’31 lines. 0 shipped bytes.

Validation

Head 45787ad7c5 on 581357bc72.

  • pnpm check:affected --run --head 45787ad7c5: all runnable checks passed, exactCommit=true. (One earlier run's vitest-related failure was a load-induced timing flake in two untouched provider-scenarios tests; both pass standalone and the rerun passed.)
  • pnpm check:xctest-selection: passes ā€” nightly reaches 499, iPad leg selects 4, 0 unreachable.
  • Focused tests: size-report-package.test.ts + xctest-selection.test.ts 34 passed; runner-source.test.ts 9 passed; prepare-publish-assets / build-package-xcuitest / packaged-runner-swift / shipped-test-code 17 passed; apple-runner-package-source.test.ts 12 passed; cache + preparation + adapter + cache-native-runtime 65 passed.
  • Mutants (disposable git worktrees, per test-audit):
    • Deleted fingerprint test: baseline runner-source.test.ts 10 passed; candidate removed + files.push(sharedHeader) deleted ā†’ retained checkout-layout test fails (1 failed | 8 passed).
    • Deleted packaged fallback: no unit test drives the resolver (all pass sourceRoot), so the retained check is the packaged-install gate. Baseline pnpm check:package -- --verify-snapshot-bridge-preparation exit 0; with the fallback deleted and the root check's path broken, verify-installed-snapshot-bridge fails with native-source-missing (exit 1); the fallback alone cannot rescue the broken path either (pre-deletion mutant, exit 1).
  • No device-code change: no simulator lane and no nightly required.
  • Self-review: no independent reviewer was available in this worker; the full diff was re-read cold instead.

git diff --stat origin/main...HEAD:

 .github/workflows/xctest-nightly.yml                   | 11 ++++++-----
 .../src/runner/__tests__/runner-source.test.ts         | 18 ------------------
 packages/platform-apple/src/snapshot-source/cache.ts   | 14 +++-----------
 scripts/package-apple-runner-source.mjs                |  3 ---
 scripts/size-report-package.mjs                        | 15 ++++++---------
 5 files changed, 15 insertions(+), 46 deletions(-)

Size Report (first commit): 0 B installed / unpacked / download; startup unchanged within noise.

šŸ¤– Generated with Claude Code