refactor(ios): drop the unused vector rotation and the duplicate round trip

Merged
TH
1d ago
+1-67

Summary

Deletes three pieces of the iPhone/iPad coordinate-space code that pin nothing. No behavior change, no scope expansion, no linked issue. Four files, 66 lines removed.

  • CoordinateSpaceRotation.native(vector:interfaceOrientation:) and its test. A repository-wide search finds no caller outside CoordinateSpaceTests.swift; dispatch uses native(point:in:) and capture uses oriented(point:rect:). Its public only serves the runner target in this repo.
  • RunnerTests+SynthesizedInteractionTests.testSynthesizedDispatchInvertsCaptureOnEveryInterfaceOrientation. Host CoordinateSpaceTests.testOrientationRotationRoundTripsBetweenInterfaceAndNativeSpace pins the same inverse identity over the same four orientations, plus unknown and an iPad-sized offset frame. Both maps are affine, so either round trip implies the other.
  • One doc line: TextEntryContentTranslation.none means the resolved window's box sits at the screen origin, not that the app fills the screen.

Validation

Head 66bf202ae168f94fc8aae971f013e5d6578832da, base 581357bc72.

  • Mutant, disposable checkout at the base: oriented's landscapeLeft row reads height - point.y. swift test --package-path apple/snapshot-presentation: base 24 tests 0 failures; candidate removed plus mutant 13 failures, led by the retained round-trip test. Worktree removed.
  • pnpm gate ios-snapshot-differential: Swift 23 tests 0 failures; 12 TypeScript tests pass.
  • Runner unit lane, unit-test compile flag on, the 16 RunnerTests+SynthesizedInteractionTests methods: iPhone 17 Pro Max 16 passed, iPad Air 11-inch (M4) 16 passed, 0 failures.
  • pnpm check:affected --run --head 66bf202ae: passed, exactCommit=true. check:xctest-selection: 0 methods dark.
  • Apple / Smoke Tests failed once on an infrastructure fault in its log (hashFiles(...) timed out at 120 s, skipping the iOS XCTest step). Rerun once: passed. The sole-screen route is unchanged, so no XCTest Nightly dispatch.
  • Unresolved risks: none inside the repository.

Size: installed and unpacked package -484 B, download -64 B; startup medians within noise.

šŸ¤– Generated with Claude Code