perf(check-affected): keep the related run out of the unit projects on fail-open plans too
Merged
TH
3d ago+20+20+01234567890123456789-8-8-0123456789
Summary
Follow-up to #4040. Fail-open plans run every local check, unit included, but their vitest related run still searched the unit-core and fuzz-worker projects. unitSuiteRuns now depends only on unit being a runnable check, so fail-open plans also add --project=!unit-core --project=!fuzz-worker.
Safe: the exclusion stands in for nothing. unit still runs in full, and the run stops at the first failure, so no pass skips unit. The provider-integration deferral is a stand-in, so it stays off for fail-open plans.
2 files, no scope expansion.
Validation
At 89ef2d88d7:
pnpm check:affected:test: 91/91 pass. The fail-open test asserts both exclusions pluscheck:unitand provider integration still running. A new test asserts that a fail-open plan fails on acheck:unitfailure.- Planted reds, reverted: restoring
!plan.failOpeninunitSuiteRuns, or dropping it fromrelatedSelected, fails the fail-open test. - Related run for a
package.jsonchange at load average 56-106: 2003 files / 566 s before, 164 files / 123 s after. The sameprovider-integrationcontention failures appeared in both runs. pnpm check:affected --run(FAIL-OPEN,exactCommit: true): the receipt's related command carries both exclusions and passed. Every check beforeunitpassed.unitfailed twice, in a different test each time:daemon-registration-owner.test.ts(forcedvsgraceful), thenscripts/fuzz/harness.test.tstimeouts. Each file passes on its own, andsrc/,packages/andscripts/fuzz/match main. The cause is unproven.- CI owns integration and coverage.
š¤ Generated with Claude Code