test(apple): wait for the owner lookup's spawns by event, not a turn count

Closed
TH
16h ago
+17-10

Summary

  • launch-confirmation.test.ts waited for the owner lookup's second spawn with a 1000-turn setImmediate loop. Under coverage on a loaded CI runner the lookup had not spawned at all after those turns (expected +0 to be 2), so the Coverage job failed on unrelated PRs: it is the failing test in Coverage on 5 of the last 6 failed CI runs I checked, including #4231.
  • The test now resolves a promise when the second spawn happens, and fails fast if the lookup finishes before it. The same change is bundled in #4225; this lands it alone so other PRs stop failing. #4225 can drop the identical hunk on rebase.
  • 1 file changed. Test-only.

Validation

  • Tested SHA: 0ffc0d7c3459b0b3028fdba516902987c3fbd6d2
  • pnpm check:affected --run --head 0ffc0d7c3459b0b3028fdba516902987c3fbd6d2: format, lint, typecheck, layering, fallow, vitest-related and unit passed.
  • The test file passed 15 plain runs and 5 runs under coverage with 12 CPU-burning processes.
  • Not reproduced locally: the old version also passed 5 loaded coverage runs on macOS. The failure is CI-only (Linux); the fix removes the turn bound rather than tuning it.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.