fix(android): keep alert dialog title and message in snapshot -i

Merged
TH
5d ago
+845-4

Summary

On Android, snapshot -i dropped every passive text node, so an AlertDialog showed only its buttons. This PR keeps meaningful text inside an AlertController *:id/parentPanel (platform, AppCompat, Material). All other passive text stays dropped. 6 files plus one captured fixture. Compose dialogs are out of scope (see issue). --settle and wait stable now also compare dialog text, so a changing progress dialog keeps them waiting.

Fixes #4481

Validation

Live, Android 15 emulator, Settings > Device name, android-helper 0.21.37-dev:

base eec35e9622            head d0fa5d17e1
@e4 [scroll-area]          @e4 [text] "Device name"
@e5 [text-field] "sdk_…"   @e5 [scroll-area]
@e6 [scroll-area] buttons  @e6 [text-field] "sdk_…"
@e7 [button] "Cancel"      @e7 [scroll-area] buttons
@e8 [button] "OK"          @e8 [button] "Cancel"
                           @e9 [button] "OK"

At head, App info -i still drops the "Calendar" and "App info" headers.

Fixture test fails on base: expected [ 'Back', 'Home', 'Recents', …(5) ] to include 'Device name'.

pnpm check:affected --run --head d0fa5d17e1 (exactCommit): format, lint, typecheck, layering, fallow, build, vitest-related passed. unit failed: 3 timeouts at 5000 ms in release-script and fuzz-harness tests outside this diff. Host load average was about 160, and they also time out alone. Cause unproven locally. CI passed all 22 checks at d0fa5d1, including unit, provider integration, and docs.

Independent review: no blocking findings. Not applied: one shared parentPanel literal (the existing pattern is android:-only and also drives alert detection) and a named-flags object (an existing pattern, out of scope).

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.