ci(conformance): keep the Maestro version probe's failure evidence

Merged
TH
3d ago
+499-14

Summary

The Maestro pin check hid stderr and masked CLI failures. The workflow now probes the CLI through one script that retains exit/signal/spawn diagnostics and each stream’s last 8 KiB. Only a successful CLI reporting the pinned version passes; no retry, fallback or pin change.

Version matching scans the full stdout stream independently of diagnostic retention. This preserves versions before long trailing notices and prevents truncation from turning 12.5.1 into the pinned 2.5.1. Matching state and diagnostics remain bounded.

5 touched files. No scope expansion. Closes #4455.

Validation

Head: 94f427458ddb05f56f8bcee4f387e03aad34a989.

  • Frozen install/build, full-repository formatting, focused lint and all 77 conformance tests passed locally; 14 exercise the probe.
  • Original base efe6bb9: nonzero CLI exit with matching stdout was accepted. Worker head bae08d4 rejects it and retains stderr.
  • On bae08d4, truncating 12.5.1 falsely passed; a valid pin before oversized trailing notices falsely failed. Both controls pass at this head. Oversized numeric versions also remain bounded and fail closed.
  • Exact affected validation: intermediate 8f42d7 failed scanner complexity; replaced with explicit state transitions. Current-head rerun was cancelled while waiting for live host-lock owner78515; no checks executed. CI runs the Fallow and conformance gates. Pre-existing untracked website output was preserved.
  • CI at this head: 24 checks passed, two skipped; maintainer found no code blockers. No live conformance or release dispatch. A hung CLI still inherits the workflow’s existing job timeout; this change bounds retained diagnostics, not execution time.