fix(ios): use the caller's budget for alert get and type the watchdog outcome

Merged
TH
6h ago
+118-10

Summary

alert get on iOS now spends the caller's timeout as the XCTest runner budget instead of a fixed 10 s. Floor 1.5 s (ALERT_MIN_READ_BUDGET_MS), ceiling 25 s (new ALERT_RUNNER_MAX_BUDGET_MS, below the runner's 30 s watchdog and the 90 s daemon envelope), 10 s when no timeout is given. The ceiling also bounds each runner attempt of alert wait, so a long wait polls instead of hitting the watchdog.

A watchdog expiry already reports MAIN_THREAD_TIMEOUT as reason: runner_main_thread_timeout, dispatched: unknown, distinct from ALERT_NOT_FOUND; I reused it rather than add alert_state_unknown. A follow-up read-only alert get already waits out RUNNER_BUSY or reports it; a test now pins that for alert. alert get help and commands.md state the budget and outcome. 7 files.

Cut: no new reason code, no Swift change (the runner already honored timeoutMs), no change to accept/dismiss.

Closes #4523

Validation

Head: this PR's head commit, base d78be6c887. Vitest on alert.test.ts, index-busy-resend.test.ts, command-descriptor-timeout-policy.test.ts: pass. pnpm typecheck, oxlint, pnpm format: clean. Wider vitest run of packages/command-surface, src/__tests__, test/repo-guards: only release-assets timed out (5 s, host load). CI owns the full gate.

Live, iPhone 17 simulator (iOS 27.0), worktree CLI with a temporary budget log (reverted):

  • No alert: alert get → typed alert not found. get / get 3000 / get 100 / get 90000 sent the runner 10000 / 3000 / 1500 / 25000 ms.
  • Maps location prompt: alert get 3000 read “Allow “Maps” to use your location?” with a 3000 ms budget.
  • A forced watchdog expiry was not run; unit tests cover it.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.