Rulesets: main counts the machine user's approval, as the switch of 2026-11-11 left it (#198, record 0191)

Merged
DO
6d ago
+69-6

This brings config/rulesets.json to the live main ruleset after the switch of "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198), and records the switch as decision 0191. Part of #198; it does not close it.

What GitHub holds

On the Maintainer's choice, "Switch; Factory approves", as the Factory Builder relayed it, the Factory Builder changed ruleset 24886320 through the Maintainer's login at 02:18:03Z on 2026-11-11. Four fields changed and no other:

FieldBeforeAfter
required_approving_review_count01
require_code_owner_reviewfalsetrue
require_last_push_approvalfalsetrue
dismiss_stale_reviews_on_pushfalsetrue

bypass_actors stays []. I read the live ruleset after the switch: updated_at is 2026-11-10T20:18:03-06:00 and the four fields read as above. sh tools/rulesets_drift.sh reported those four fields before this change and reports no drift after it.

What was shown before the switch

"AGENTS.md: say what is built; drop the model claim no check holds" (#688), as GitHub records it on 2026-11-11:

WhenEventActor
00:25:08ZApproved at head 2a60aef6, by the Factory's approving actdonpetry-bot
01:07:14ZAdded to the merge queuedon-petry
01:21:38ZMergeddon-petry

The Factory's queue step did not enqueue it: the queue workflow has no run on this repo. So the Factory's review and approval are shown, and its own enqueue is not. The record says so.

What changes

  • config/rulesets.json: the four fields, and read_on 2026-11-11.
  • tests/test_tools.py:
    • test_main_counts_the_machine_users_approval_as_the_switch_left_it holds the committed record to the switch: the four fields, no required reviewer, no bypass, the ruleset's id, and a read date of the switch day or after. tools/check_rulesets.py holds how an approval is counted, and still lets through a main that counts none, so without this test the record could go back with nothing failing.
    • The Rulesets tests' run_on now carries the repo's own .github/CODEOWNERS. The check reads the code owners once main counts an approval, and test_this_repos_rulesets_agree_with_its_lenses failed without them.
  • tools/mutants.py: six mutants of config/rulesets.json, each killed by the new test: each field back, the four together, and the read date back.
  • Record 0191: the switch, what a merge now needs, what is not shown yet, what it overtakes in records 0018, 0020, 0022, 0026 and 0087, and the undo.

What it does not do

  • tools/check_rulesets.py is unchanged: it does not refuse a main that counts no approval. A check that refused it would refuse the undo's record too.
  • config/AGENTS.md is unchanged: its row on how main counts an approval already reads in the present, and the file is at its 40-line limit.
  • A comment in sim/world.py still speaks of the switch as to come. That file is protected, so it is left for a ruling.
  • The diff is 12,384 characters and 131 lines, under the Factory's review budget.
  • How a fix merges while the Release on next is broken (#198's third box) is not shown, and the record says so.

Checks

CheckResult
make checksOK
tests.test_tools.Rulesets, RulesetsDriftOK, 25 tests
Mutants of config/rulesets.json, tools/check_rulesets.py and tools/rulesets_drift.py, run alone on an export56 of 56 killed, at 924fb48; the head differs from it in the record's words alone
sh tools/rulesets_drift.shno drift
Full make verifyNot run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
ReviewerHeadUnread partsBlockingMajorMinorInfo
agy (Carbon)d207d86none0000
mused207d86none1000
astraa04c419none0000
claude-reviewd207d86none0112
claude-securityd207d86none0100

The head is 8fc5492. It differs from a04c419, which Astra read clean, in the record alone: its number, and the three rows a review comment on this pull request led to (below). a04c419 differs from d207d86 in the record's words, the test's read-date case and one mutant.

FindingWhatDisposition
muse@d207d86 #1 (blocking)The record was numbered one past a number main did not hold, so make checks failedfixed: the record is 0191. The Factory Builder ruled that numbers go in order of readiness; the Pause record, whose pull request was split, takes the next
claude-security@d207d86 #1 (major), claude-review@d207d86 #1 (major)The record said the Factory's queue step enqueued #688 with no person's act between; GitHub names don-petry as the enqueuer, and the queue workflow has never runfixed: the row says who enqueued and that the Factory's enqueue is not shown
claude-review@d207d86 #2 (minor)Records 0018, 0020, 0022, 0026 and 0087 still say main requires no review, and 0191 named only 0092fixed: the row "What it overtakes"
claude-review@d207d86 #3 (info)Nothing held read_onfixed: the test holds it, with a mutant
cubic on 924fb48, three threadsThe record said every merge needs the machine user's approval, where the ruleset asks for a code owner's; the Decision table told the dry run's history; and numbers were said to need spelling outthe first two fixed at 8fc5492: the row names a code owner's approval and when it is the machine user's, and the history is in the Why. The third is no change: the rule is the title and then the number after the word
claude-review@d207d86 #4 (info)The reviewer did not read the live ruleset or the time of the switchanswered above: I read both

šŸ¤– Generated with Claude Code