fix: Setup no longer reports optional npm cleanup failures
Merged
HA
3mo ago+74+74+01234567890123456789-168-168-012345678901234567890123456789
Summary
- Setup no longer prints manual cleanup instructions when optional removal of an older npm-installed command cannot finish.
- Windows setup still warns when a persisted PATH entry would make new shells resolve the older command instead of the native CLI.
User Impact
- Users upgrading to the native CLI no longer see a confusing legacy npm cleanup failure message for an optional cleanup step.
- If an older command still shadows the native CLI for future Windows shells, Setup continues to show PATH guidance instead of silently claiming everything is ready.
Changes
- Removed legacy npm cleanup failure output from the POSIX and PowerShell installers while keeping the successful cleanup message.
- Kept Windows path-shadowing detection based on persisted Machine and User PATH entries.
- Updated installer regression tests to match the quieter cleanup behavior.
- Bumped the dispatcher release version because installer files are dispatcher release inputs.
Verification
go test ./internal/install -run TestCommandForWindowsConfiguresUserPathAndLegacyCleanupscripts/test-install-release-filter.shgo test ./internal/installscripts/check-go-cli.shgo run ./cmd/check-dispatcher-version-bump --base origin/v3-beta --head HEADautoreview --mode branch --base origin/v3-beta