chore: remove unused Roslyn worker cleanup test hook

Merged
HA
3mo ago
+1-16

Summary

  • Remove an unused Roslyn worker directory cleanup test hook after its only consumer was deleted for EditMode freeze prevention.
  • Keep production temporary-directory cleanup and failure logging unchanged.

User Impact

  • No user-visible behavior changes are intended.
  • Shared compiler worker shutdown still deletes its temporary directory directly and still logs IOException or UnauthorizedAccessException cleanup failures.

Changes

  • Remove the unused host facade and session swap method for the worker directory deleter.
  • Remove the delegate field whose only purpose was supporting that test seam.
  • Invoke the delegate's original production operation, Directory.Delete(path, true), directly inside the existing cleanup try/catch.

Verification

  • Confirmed the removed identifiers had no rooted C#, test, tooling, JSON, Markdown, serialization, or reflection references.
  • Confirmed history: the seam's only test was removed with the real-worker EditMode fixture in the freeze-prevention change.
  • Unity compile: 0 errors, 0 warnings.
  • SharedRoslynCompilerWorkerHostTests: 23/23 passed.
  • ExternalCompilerPathResolverTests: 15/15 passed.
  • StaticFacadeStateGuardTests: 20/20 passed.
  • Public/type and member/local dead-code scanner passes completed; removed identifiers are absent.
  • git diff --check: passed.

Compatibility

  • Directory existence checks, session state clearing, lock boundaries, exception filters, warning payloads/messages, and lifecycle callers are unchanged.
  • No public API or IPC protocol declaration changed.