> [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > >

⚠️ Outside diff range comments (1)

> >
>
Sources/Bonsplit/Internal/Views/TabBarView.swift (1)
> > `671-682`: _⚠️ Potential issue_ | _🟠 Major_ > > **Refresh the hint-policy tests for the new flags-based return value.** > > Line 681 and Line 682 now return `.flags(...)`, but `Tests/BonsplitTests/BonsplitTests.swift:623-624` still expect `.command` and `.control`. That leaves the test target broken until those assertions are updated to the new enum shape. > >
>
Suggested follow-up in Tests/BonsplitTests/BonsplitTests.swift
> > ```diff > -XCTAssertEqual(TabControlShortcutHintPolicy.hintModifier(for: [.command], defaults: defaults), .command) > -XCTAssertEqual(TabControlShortcutHintPolicy.hintModifier(for: [.control], defaults: defaults), .control) > +XCTAssertEqual( > + TabControlShortcutHintPolicy.hintModifier(for: [.command], defaults: defaults), > + .flags([.command]) > +) > +XCTAssertEqual( > + TabControlShortcutHintPolicy.hintModifier(for: [.control], defaults: defaults), > + .flags([.control]) > +) > ``` >
> >
>
🤖 Prompt for AI Agents
> > ``` > Verify each finding against the current code and only fix it if needed. > > In `@Sources/Bonsplit/Internal/Views/TabBarView.swift` around lines 671 - 682, The > tests still assert the old enum cases (.command and .control) but the function > TabBarView.hintModifier(for:defaults:) now returns > TabControlShortcutModifier.flags(...) with surface/workspace masks; update the > test assertions in the BonsplitTests to expect .flags(...) instead of > .command/.control and construct the expected value by calling > resolvedSurfaceFlags(defaults:) and resolvedWorkspaceFlags(defaults:) (or by > using the same flag masks used in production) so the assertions compare > TabControlShortcutModifier.flags(resolvedSurfaceFlags(...)) and > TabControlShortcutModifier.flags(resolvedWorkspaceFlags(...)). > ``` > >
> >
> >

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Outside diff comments: In `@Sources/Bonsplit/Internal/Views/TabBarView.swift`: - Around line 671-682: The tests still assert the old enum cases (.command and .control) but the function TabBarView.hintModifier(for:defaults:) now returns TabControlShortcutModifier.flags(...) with surface/workspace masks; update the test assertions in the BonsplitTests to expect .flags(...) instead of .command/.control and construct the expected value by calling resolvedSurfaceFlags(defaults:) and resolvedWorkspaceFlags(defaults:) (or by using the same flag masks used in production) so the assertions compare TabControlShortcutModifier.flags(resolvedSurfaceFlags(...)) and TabControlShortcutModifier.flags(resolvedWorkspaceFlags(...)). ```

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro **Run ID**: `52396ded-4d5d-4333-979d-c89f3c6914ea`

📥 Commits

Reviewing files that changed from the base of the PR and between efa23f4c3c7d00688d8448dc7e4d08b4d847548d and b5a0c933f68927bc6e1dd7215b3d1b206b3c5954.

📒 Files selected for processing (1)

* `Sources/Bonsplit/Internal/Views/TabBarView.swift`