> [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > >

⚠️ Outside diff range comments (1)

> >
>
Sources/ContentView.swift (1)
> > `1206-1221`: _⚠️ Potential issue_ | _🟡 Minor_ > > **Scope the `">"` selection normalization to the command palette search field.** > > The command-mode prefix semantics (restoring caret-at-end for `">"` queries) are specific to the palette search field. However, `isPaletteTextInputFirstResponder(editor)` at line 1209 matches any editable NSTextView descendant of `containerView` when it's not a field editor (line 1086 in the helper), which could include workspace/tab rename fields. A rename field starting with `">"` would incorrectly have its full selection normalized away on refocus. > > Use `isPaletteFieldEditor(editor)` instead to ensure this normalization applies only to the palette's search field. > >
>
🛠️ Suggested fix
> > ```diff > guard let window, > let editor = window.firstResponder as? NSTextView, > - isPaletteTextInputFirstResponder(editor) else { return } > + isPaletteFieldEditor(editor) else { return } > ``` >
> >
>
🤖 Prompt for AI Agents
> > ``` > Verify each finding against the current code and only fix it if needed. > > In `@Sources/ContentView.swift` around lines 1206 - 1221, The normalization in > normalizeSelectionAfterProgrammaticFocus is currently gated by > isPaletteTextInputFirstResponder(editor) which matches any editable NSTextView > descendant and can wrongly affect rename fields; change the guard to use > isPaletteFieldEditor(editor) instead so the caret-at-end restoration only runs > for the palette's search field (update the guard that checks > isPaletteTextInputFirstResponder to call isPaletteFieldEditor with the same > editor variable). > ``` > >
> >
> >

♻️ Duplicate comments (1)

Sources/ContentView.swift (1)
`1129-1154`: _⚠️ Potential issue_ | _🟠 Major_ **Guard the async focus retries on palette/window state.** `updateFocusLockForWindowState()` now cancels `scheduledFocusWorkItem`, but the `asyncAfter` tail here is independent. If the window resigns key or the palette hides after the first retry starts, a late callback can still run `makeFirstResponder(...)` and yank focus back from the emoji/system panel.

🛠️ Suggested fix
```diff private func focusIntoPalette(retries: Int) { - guard let window else { return } + guard let window, isPaletteVisible, window.isKeyWindow else { return } if isPaletteTextInputFirstResponder(window.firstResponder) { return } ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@Sources/ContentView.swift` around lines 1129 - 1154, The async retry in focusIntoPalette can run after the palette/window state changes because it uses DispatchQueue.main.asyncAfter directly; replace that tail with a cancellable DispatchWorkItem stored in scheduledFocusWorkItem (the same token updateFocusLockForWindowState cancels) or otherwise guard the retry by checking the palette/window state before attempting focus: capture self weakly, create a DispatchWorkItem that first verifies the window is still key and the palette is visible (the same conditions used elsewhere), then calls focusIntoPalette(retries: -1); assign that work item to scheduledFocusWorkItem so updateFocusLockForWindowState can cancel it, and when canceled do not call makeFirstResponder on containerView/firstEditableTextInputView. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Outside diff comments: In `@Sources/ContentView.swift`: - Around line 1206-1221: The normalization in normalizeSelectionAfterProgrammaticFocus is currently gated by isPaletteTextInputFirstResponder(editor) which matches any editable NSTextView descendant and can wrongly affect rename fields; change the guard to use isPaletteFieldEditor(editor) instead so the caret-at-end restoration only runs for the palette's search field (update the guard that checks isPaletteTextInputFirstResponder to call isPaletteFieldEditor with the same editor variable). --- Duplicate comments: In `@Sources/ContentView.swift`: - Around line 1129-1154: The async retry in focusIntoPalette can run after the palette/window state changes because it uses DispatchQueue.main.asyncAfter directly; replace that tail with a cancellable DispatchWorkItem stored in scheduledFocusWorkItem (the same token updateFocusLockForWindowState cancels) or otherwise guard the retry by checking the palette/window state before attempting focus: capture self weakly, create a DispatchWorkItem that first verifies the window is still key and the palette is visible (the same conditions used elsewhere), then calls focusIntoPalette(retries: -1); assign that work item to scheduledFocusWorkItem so updateFocusLockForWindowState can cancel it, and when canceled do not call makeFirstResponder on containerView/firstEditableTextInputView. ```

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro **Run ID**: `6150eadf-02e7-4095-8bc4-6d63101f3ef6`

📥 Commits

Reviewing files that changed from the base of the PR and between f9ae7c09477bf80aa616a5adcef42756689484e1 and 0b07651e4161ce706621e611fcfeff51f0a12fed.

📒 Files selected for processing (1)

* `Sources/ContentView.swift`