cmux NEXT Settings: a group title never repeats its page's title (Updates, Advanced)

Merged
TE
5d ago
+180-3

Leo, 2026-10-30, on Settings > Updates: "look for wastage".

Settings > Updates drew its title twice: "Updates" as the page title, then "Updates" again over its first group, then "Updates: Advanced" over the second. design/settings.md lists it under Not yet settled ("A group whose title repeats its page's title is a candidate for the same waste rule").

What changes

  • On a category page, a group whose title is the page's own title draws no title. A group whose title starts with the page title and a colon drops that prefix ("Updates: Advanced" reads "Advanced").
  • Search results keep each group's whole title. In search, the title is the only thing that says which page a row comes from.
  • Rows, groups, their order, the schema and the Swift layout don't change (GroupList shownGroupTitle, the page title passed from SectionView). Updates is the only page today whose group title repeats its page title. The DOM test checks every category page so a new one is caught.

Tests (red at the first commit, green at the head)

  • webviews/src/pages/settings/groupTitles.test.tsx: the rule's cases; Updates draws ["Advanced"] only; no category page draws a group title equal to its own title; search keeps "Updates".
  • webviews/test/settings-group-titles-browser.test.ts: Chromium on the gallery's pages.settings variant updates. It checks the visible group titles and writes 2x light and dark stills.

Stills

Gallery (pages.settings, updates), Chromium, synthetic data, light and dark: to follow from the cmux-ci runs at the red commit (before) and the head (after).

Observed / Not run

  • Observed: lints on the changed files (vp fmt, browser-lane check). web-lint's other failures are base debt in files this PR doesn't touch (check-design-tokens and check-layers on pages/settings/styles.css, vp fmt on the context-menu files).
  • Not run yet: the two tests (they go to cmux-ci; no local heavy runs on this VM).

Changelog

Changed: Settings > Updates no longer repeats "Updates" over its groups; the advanced group reads "Advanced".

Design spec: leo-workspace design/settings.md (moves its first "Not yet settled" item into Rules in a follow-up).

Agent session: agent session

šŸ¤– Generated with Claude Code