base red: acpmux clippy redundant_closure in process_values
Summary
Base red fix (priority zero). clippy -D warnings refuses .map(|path| length(path)) at cmux-tui/crates/acpmux/src/hub/processes.rs:256 (clippy::redundant_closure, from 704abda602b). That fails clippy (changed cmux-tui packages) on every PR that touches a crate that depends on acpmux. Other branches hit it too (QUIT P0's holder2 proof 6298c55e). This passes the function by reference: .map(&length). The behavior does not change.
Command: scripts/ci/cmux-tui-rust-check.sh clippy on the fleet.
-
Base 05f7dc9a92ce (red): Linux e926c1b3c85f52aa42b3ceca (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265354797):
error: redundant closure --> crates/acpmux/src/hub/processes.rs:256:71,could not compile acpmux, RED. macOS 62f454b7855512fbf139701e (aws-m4pro-6): the sameredundant closureerror at processes.rs:256:71, RED. -
Head 3bd06a7fe7e8 (green): Linux 1f0346de6fdaff4d3108b119 (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265354780): clippy
-D warningson the workspace, green. macOS 7c7beddd0240e1cba28c2b05 (aws-m4pro-3): green. -
Head 3bd06a7fe7e8, full step: job 08b7447166f7ff2e95a126d1 (https://github.com/manaflow-ai/cmuxterm-hq/actions/runs/41265127942): fmt pass, clippy
-D warningspass,a_process_list_reads_output_metadata_after_releasing_its_table(the test that callsprocess_values) 1/1 pass, 0 flaky.
Observed / Not run
- Observed: the four fleet clippy jobs above (logs read: each red has only this one error; each green has none).
- Observed: the diff is one line;
lengthisimpl Fn(&str) -> u64, and&lengthisFn(&str) -> u64, soOption<&str>::map(&length)gives the sameOption<u64>. - Not run: the full test suite (no behavior change).
Changelog
none