Unmask right sidebar chrome E2E tests
Summary
- remove non-strict expected-failure launch wrappers from
RightSidebarChromeHeightUITests - update stale chrome assertions so visual 28 pt metrics are not compared to 48 pt accessibility hit targets
- cover the same stale assertion in
BonsplitTabDragUITests
Verification
- failing baseline: https://github.com/manaflow-ai/cmux/actions/runs/26576147383
- passing focused E2E: https://github.com/manaflow-ai/cmux/actions/runs/26576700096
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.
[!NOTE]
Low Risk
Test-only changes to XCTest expectations and launch handling; no production UI or app logic.
Overview
Unmasks right-sidebar chrome E2E tests so launch failures surface on CI instead of being swallowed by non-strict XCTExpectFailure around app.launch() in RightSidebarChromeHeightUITests.
Fixes outdated height checks that compared 28 pt in-app chrome metrics to Bonsplit pane tab frames from XCUITest. Those elements can be taller because of accessibility hit targets (~48 pt). Assertions now require the tab’s frame height to be at least the compact lane height, not equal to it—the same change in BonsplitTabDragUITests for the cross-presentation-mode mode-bar test.
Reviewed by Cursor Bugbot for commit 527aca4181981956049494f0638b2a51b0e51243. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Unmasked the right sidebar chrome UI tests and fixed hit-target assertions so we compare 28 pt chrome lanes against 48 pt tab targets. Improves reliability on CI and aligns tests with intended visual vs accessibility metrics.
- Bug Fixes
- Removed non-strict expected-failure wrappers; launch app directly in
RightSidebarChromeHeightUITests. - Replaced equality checks with greater-or-equal for tab hit target vs 28 pt chrome lane.
- Added matching assertion coverage to
BonsplitTabDragUITests.
- Removed non-strict expected-failure wrappers; launch app directly in
Summary by CodeRabbit
Release Notes
- Tests
- Improved test stability by removing app launch failure expectations on headless CI runners.
- Enhanced UI height verification tests with more flexible assertions to ensure proper hit-target coverage for interface elements across different presentation modes.
