🧹 Nitpick comments (1)

src/config/CApi.zig (1)
`93-109`: **Add focused tests for the new color-scheme setter behavior.** Please add coverage for DARK, LIGHT, and invalid inputs (including “state unchanged on invalid”) to prevent regressions in pre-finalize theme resolution.

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@src/config/CApi.zig` around lines 93 - 109, Add scoped unit tests exercising ghostty_config_set_color_scheme: verify that passing 0 sets Config._conditional_state.theme to .light, passing 1 sets it to .dark, and passing an invalid integer leaves _conditional_state.theme unchanged and logs a warning; specifically, create tests that initialize a Config with a known starting theme, call ghostty_config_set_color_scheme for LIGHT (0) and DARK (1) and assert the theme value changes accordingly, then call it with an invalid value and assert the theme remains the pre-call value while a warning was emitted. Ensure tests invoke ghostty_config_set_color_scheme directly and assert on Config._conditional_state.theme and the logging side-effect to cover all three behaviors. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Nitpick comments: In `@src/config/CApi.zig`: - Around line 93-109: Add scoped unit tests exercising ghostty_config_set_color_scheme: verify that passing 0 sets Config._conditional_state.theme to .light, passing 1 sets it to .dark, and passing an invalid integer leaves _conditional_state.theme unchanged and logs a warning; specifically, create tests that initialize a Config with a known starting theme, call ghostty_config_set_color_scheme for LIGHT (0) and DARK (1) and assert the theme value changes accordingly, then call it with an invalid value and assert the theme remains the pre-call value while a warning was emitted. Ensure tests invoke ghostty_config_set_color_scheme directly and assert on Config._conditional_state.theme and the logging side-effect to cover all three behaviors. ```

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro **Run ID**: `b5a5606f-fe26-4ad8-b525-d9c8229c47ba`

📥 Commits

Reviewing files that changed from the base of the PR and between 3b684a085d40ec79e8a0ae863a4f2b48ed4dba74 and e0f6eba3d0d00bb6d312d1e65e5b868de4e9c89c.

📒 Files selected for processing (2)

* `include/ghostty.h` * `src/config/CApi.zig`