**Actionable comments posted: 1**

🧹 Nitpick comments (1)

app/src/main/java/com/mobilenext/devicekit/PackageLister.java (1)
`60-70`: **Close the per-package `AssetManager`.** `AssetManager` is `AutoCloseable` and exposes `close()`. Since this loop allocates one per package, not closing it retains native resources until process exit; wrap the label lookup in `finally`. ([android.googlesource.com](https://android.googlesource.com/platform/frameworks/base/%2B/android-9.0.0_r3/core/java/android/content/res/AssetManager.java?utm_source=openai))

♻️ Proposed fix
```diff - AssetManager assets = AssetManager.class.getDeclaredConstructor().newInstance(); - Method addAssetPath = AssetManager.class.getMethod("addAssetPath", String.class); - addAssetPath.invoke(assets, appInfo.sourceDir); - Resources res = new Resources(assets, new DisplayMetrics(), new Configuration()); - String label = res.getString(appInfo.labelRes); - if (label != null && !label.isEmpty()) { - displayName = label; - } + AssetManager assets = AssetManager.class.getDeclaredConstructor().newInstance(); + try { + Method addAssetPath = AssetManager.class.getMethod("addAssetPath", String.class); + addAssetPath.invoke(assets, appInfo.sourceDir); + Resources res = new Resources(assets, new DisplayMetrics(), new Configuration()); + String label = res.getString(appInfo.labelRes); + if (label != null && !label.isEmpty()) { + displayName = label; + } + } finally { + assets.close(); + } ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@app/src/main/java/com/mobilenext/devicekit/PackageLister.java` around lines 60 - 70, The created per-package AssetManager in the try block (AssetManager assets = AssetManager.class.getDeclaredConstructor().newInstance(); used with addAssetPath and Resources) is not closed and leaks native resources; update the code around AssetManager/assets (and the label lookup that uses appInfo.labelRes and Resources) to use try-with-resources or ensure assets.close() is called in a finally block after obtaining the label, so each AssetManager is closed for every package iteration before continuing and displayName assignment remains unchanged. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Inline comments: In `@app/src/main/java/com/mobilenext/devicekit/PackageLister.java`: - Around line 39-41: The reflection call in PackageLister that retrieves getInstalledPackages on ipm currently assumes the signature getInstalledPackages(long,int) and hardcodes userId 0, which will fail on older Android (e.g., Android 10) that exposes getInstalledPackages(int,int) and ignores multi-user installs; update the logic in PackageLister to try a fallback chain: first attempt ipm.getClass().getMethod("getInstalledPackages", long.class, int.class) and invoke it if present, then catch NoSuchMethodException and try ipm.getClass().getMethod("getInstalledPackages", int.class, int.class) and invoke that instead, mapping the long argument to an int when using the older signature; also add a parameter to the PackageLister API (or method where this reflection occurs) to accept a targetUserId instead of hardcoding 0 and pass that value when invoking either signature so packages for the requested user are returned. --- Nitpick comments: In `@app/src/main/java/com/mobilenext/devicekit/PackageLister.java`: - Around line 60-70: The created per-package AssetManager in the try block (AssetManager assets = AssetManager.class.getDeclaredConstructor().newInstance(); used with addAssetPath and Resources) is not closed and leaks native resources; update the code around AssetManager/assets (and the label lookup that uses appInfo.labelRes and Resources) to use try-with-resources or ensure assets.close() is called in a finally block after obtaining the label, so each AssetManager is closed for every package iteration before continuing and displayName assignment remains unchanged. ```

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR: - [ ] Push a commit to this branch (recommended) - [ ] Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `e28ae274-308c-405a-880e-584910ca1dba`

📥 Commits

Reviewing files that changed from the base of the PR and between 6d53fb169c6edc34053c4f8b0accfe52141fa463 and facfcb53ce0b7ceefd0caa166278ccb4b588a3a8.

📒 Files selected for processing (1)

* `app/src/main/java/com/mobilenext/devicekit/PackageLister.java`