fix(auth): return RFC 6749 compliant OAuth error codes for token and revoke (#3723)
Closed
PY
25d ago+108+108+012345678901234567890123456789-8-8-0123456789
Description
Addresses #3723 by ensuring RFC 6749 §5.2 and RFC 7009 §2.2.1 compliance for OAuth 2.0 error responses in the token and revocation endpoints:
- Token endpoint (
/token):- When a requested grant type is unsupported by the authorization server (e.g.
client_credentials,password), returnunsupported_grant_type(status 400) rather than failing discriminator validation withinvalid_request. - When an authenticated client is not authorized to use the requested grant type (i.e.
token_request.grant_type not in client_info.grant_types), returnunauthorized_client(status 400) per RFC 6749 §5.2 ("The authenticated client is not authorized to use this authorization grant type"), rather thanunsupported_grant_type.
- When a requested grant type is unsupported by the authorization server (e.g.
- Revocation endpoint (
/revoke):- When client authentication fails (
AuthenticationError), returnerror="invalid_client"with status 401 per RFC 7009 §2.2.1 and RFC 6749 §5.2 ("Client authentication failed"), rather thanunauthorized_client. - Extended
RevocationErrorResponseto allowinvalid_client.
- When client authentication fails (
Testing
- Added regression tests in
tests/server/auth/test_error_handling.py:test_token_unsupported_grant_type_returns_unsupported_grant_typetest_token_unauthorized_client_grant_type_returns_unauthorized_clienttest_revoke_invalid_client_authentication_returns_401
- Updated
test_identity_assertion.pyto assertunauthorized_clientwhen a registered client is not authorized for the grant. - Verified all 175 tests in
tests/server/authandtests/interaction/authpass. - Formatted and linted with
ruff.
Closes #3723