feat: implement issue #1905 — [qa-lead reach 3/3] persona-runner ignores surface=pull_request — the router-served qa-lead advisory loses its test-surface, budget and already-advised gates

Merged
DO
15d ago
+634-113

Problem

[qa-lead reach 3/3] persona-runner ignores surface=pull_request — the router-served qa-lead advisory loses its test-surface, budget and already-advised gates

From the issue: Epic #1643 (Phase 2), decision (b) in ADR-0009 (#1869): qa-lead's pull_request advisory moves from the self-contained .github/workflows/qa-lead-pr-advisory.yml to the shared persona-mention router (petry-projects/.github#1165, PR petry-projects/.github#1167). The router dispatches repository_dispatch: persona-mention with client_payload[surface]=pull_request into .github/workflows/persona-runner.yml here.

Risk

Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.

Test plan

Tests added/updated: tests/test_persona_pr_pregate.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.

Closes #1905