feat: implement issue #2045 — dev-lead: no deferred/out-of-scope outcome for review threads — a valid finding dev-lead defers stays unresolved forever and blocks merge

Merged
DO
20d ago
+1542-57

Problem

dev-lead: no deferred/out-of-scope outcome for review threads — a valid finding dev-lead defers stays unresolved forever and blocks merge

From the issue: When dev-lead decides a bot review-thread finding is valid but out of scope for the PR, it replies with a skip note ("Valid, but deferring — out of scope") and the thread stays unresolved forever. Under required_review_thread_resolution that blocks merge, and no automated actor can clear it.

Risk

Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.

Test plan

Tests added/updated: tests/dev-lead/unit/test_deferred_thread_verify.bats,tests/dev-lead/unit/test_fix_reviews.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.

Closes #2045