fix: Compose OAuth behavior annotations with current catalog

Merged
SI
5d ago
+612-83

Problem and result

OAuth tool annotations must describe side effects consistently across full and limited discovery. This successor preserves candidate #1238 and normally composes it with current main 10fce9198fc4bacf184405e7792563fec90f7496. Current head: c7e2a2e70c75602cb781f9b6ce6bfd91666ea080.

Explicit read-only, destructive and open-world policy covers the full and limited registries, including three current social tools. Discovery tests verify 94 full registrations / 93 model-visible tools and 7 limited registrations / 6 model-visible tools. Standard-only catalog preparation and ingestion remain excluded. Handler behavior, schemas, authentication and scopes are unchanged.

Validation and reviews

Focused discovery/annotation tests passed (3 files, 7 tests), as did local lint, production types and contract checks on the original successor. The 12 contribution files and complete contribution patch remain byte-identical through both normal main merges. Incoming Sites files match accepted main exactly. Fresh final-head required CI is tracked below by GitHub.

Independent exact-head Spec: 0 findings. Standards: 0 findings. Codex completed with zero findings and Cubic reviewed 12/12 files at 50cad80d (reported coverage 94%); Cubic skipped subsequent merge-only commits. Those automated reviews cover the unchanged contribution, not an exact-head automated composition review.

CodeRabbit's pre-merge warning uses stale 60af5644 base. Catalog/LinkedIn refactors it attributes to this PR are already in main. The catalog annotation mismatch was subsequently corrected narrowly in standard registration without granting delegated access. Repeated policy triples are an intentional audit inventory. Independent triage found no actionable in-scope correction; this does not erase the warning or claim a completed full CodeRabbit review.

Release boundary

Both deployment guards remain false: fix/mcp-oauth-behavior-annotations and codex/oauth-annotations-current-main. Original draft #1238 is untouched. Ready status allows automated review only. Coordinator owns merge/release approval. The source-release decision below authorizes the normal main merge and its normal deployment; plugin resubmission remains unapproved.

For deployed metadata acceptance and broader client release sign-off, verify authenticated tools/list on the exact endpoint in both existing OAuth modes and the four standard Catalog metadata tuples through an already authorized client. Deployed database settlement and native-client behavior remain separate owning-epic acceptance. No business tool execution, new grant, migration or credential discovery is authorized by this source release.

New exact-head review corrections

The later Cubic findings on 4e5b1ee were inspected separately from prior triage. Corrected export settlement/refund wording (4605071264), image generation rationale (4605071310), six combined source links (4605071333), and explicit limited-tool visibility assertions (4605071324). For 4605071285, catalog saves retain history but replace the current revision: retained destructive:true and aligned standard registration with shared metadata. Added discovery-only standard assertions; all four catalog tools remain delegated:false and excluded from OAuth.

Style comments 4605071230/1243/1257/1296: no tracked universal100-line file cap was found. Retained cohesive policy inventories and regression coverage. The existing long registration function remains maintainability debt under the actual function-length guidance; no auth/schema refactor was added.

Independent fix-diff Spec and Standards reviews: zero actionable findings. Focused tests passed4files/8tests after reproducing the standard annotation mismatch; local lint and OAuth types passed. Exact-head format, lint, compatibility and test workflows all pass. Cubic completed review of the five-file correction with zero new issues (5/5 confidence). Five earlier GitHub threads remain unresolved: the four style suggestions and the catalog metadata suggestion; their reasoned dispositions above require coordinator review, not an auto-approval claim. Guards and original1238 remain untouched.

Coordinator source-release decision

Recoup OS accepts exact c7e2a2e70c75602cb781f9b6ce6bfd91666ea080 for a normal metadata source release under the October 19 standing delivery authority. Required exact-head checks passed; independent source, Catalog-contract and reconciliation release-scope reviews found no unresolved blocking defect. Discovery hints/descriptions and the narrow standard Catalog metadata projection change; handlers, schemas, authentication, scopes, delegated exclusions and business permissions remain unchanged. The two feature-branch deployment guards remain intact.

This explicitly separates the present metadata correction from the earlier broad “before any release” wording. Authenticated deployed discovery, native-client acceptance, Pack settlement correctness and whole-epic completion remain unproven and open. They are not claimed by source tests or this decision. Observe normal post-merge CI/deployment and exact revision readback; do not use mutating Pack reads/exports as smoke tests. No manual deployment, business activation, provider call, spending, database apply or plugin resubmission is included.