🧹 Nitpick comments (2)

lib/agents/content/handlers/registerOnNewMention.ts (2)
`21-22`: **Consider extracting hardcoded UUIDs to configuration.** These hardcoded account IDs reduce flexibility and make testing more difficult. Consider moving them to a configuration object or environment variables, or accepting them as parameters. ```diff - const accountId = "fb678396-a68f-4294-ae50-b8cacf9ce77b"; - const artistAccountId = "1873859c-dd37-4e9a-9bac-80d3558527a9"; + const accountId = config.contentAgent.defaultAccountId; + const artistAccountId = config.contentAgent.defaultArtistAccountId; ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@lib/agents/content/handlers/registerOnNewMention.ts` around lines 21 - 22, Replace the hardcoded UUIDs in registerOnNewMention.ts by reading them from configuration or parameters: stop using the inline constants accountId and artistAccountId and instead obtain their values from a config object/environment variables or function arguments (e.g., config.accountId / process.env.ACCOUNT_ID or add parameters to registerOnNewMention). Update any call sites that construct or invoke registerOnNewMention to pass the IDs if you choose parameters, and add sensible defaults/fallbacks and validation for missing/invalid IDs. ```
--- `19-137`: **Inner callback exceeds recommended function length.** The `onNewMention` callback spans ~118 lines and handles multiple distinct responsibilities: prompt parsing, attachment extraction, artist resolution, repo lookup, acknowledgment posting, content triggering, and polling setup. Consider extracting cohesive steps into focused helper functions (e.g., `resolveArtistContext`, `buildContentPayload`, `postAcknowledgment`) to improve testability and readability. This aligns with the Single Responsibility Principle and the guideline to keep functions under 50 lines. As per coding guidelines: "Flag functions longer than 20 lines" and "Keep functions under 50 lines".

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@lib/agents/content/handlers/registerOnNewMention.ts` around lines 19 - 137, The onNewMention callback is too large and handles multiple responsibilities; refactor it by extracting cohesive helper functions: implement resolveArtistContext(accountId, artistAccountId) to encapsulate resolveArtistSlug, getArtistContentReadiness and fallback selectAccountSnapshots logic; implement buildContentPayload({accountId, artistSlug, template, lipsync, captionLength, upscale, githubRepo, songs, imageUrls}) to construct the payload currently assembled inline; and implement postAcknowledgment(thread, {artistSlug, template, batch, lipsync, songs, songUrl, imageUrls}) to handle the details message and initial thread.post. Replace the large inline blocks in onNewMention with calls to these helpers and keep error handling and polling (triggerCreateContent, triggerPollContentRun) in the top-level callback. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Nitpick comments: In `@lib/agents/content/handlers/registerOnNewMention.ts`: - Around line 21-22: Replace the hardcoded UUIDs in registerOnNewMention.ts by reading them from configuration or parameters: stop using the inline constants accountId and artistAccountId and instead obtain their values from a config object/environment variables or function arguments (e.g., config.accountId / process.env.ACCOUNT_ID or add parameters to registerOnNewMention). Update any call sites that construct or invoke registerOnNewMention to pass the IDs if you choose parameters, and add sensible defaults/fallbacks and validation for missing/invalid IDs. - Around line 19-137: The onNewMention callback is too large and handles multiple responsibilities; refactor it by extracting cohesive helper functions: implement resolveArtistContext(accountId, artistAccountId) to encapsulate resolveArtistSlug, getArtistContentReadiness and fallback selectAccountSnapshots logic; implement buildContentPayload({accountId, artistSlug, template, lipsync, captionLength, upscale, githubRepo, songs, imageUrls}) to construct the payload currently assembled inline; and implement postAcknowledgment(thread, {artistSlug, template, batch, lipsync, songs, songUrl, imageUrls}) to handle the details message and initial thread.post. Replace the large inline blocks in onNewMention with calls to these helpers and keep error handling and polling (triggerCreateContent, triggerPollContentRun) in the top-level callback. ```

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro **Run ID**: `27dd356c-d284-4a26-9f4b-217a5c111013`

📥 Commits

Reviewing files that changed from the base of the PR and between 3d7ce43e1fd2b17325e2c5fb53a71f0fabd38599 and 4b2e488b82ad6a369eb7d3d616041cc673e9ca77.

⛔ Files ignored due to path filters (2)

* `lib/agents/content/__tests__/extractMessageAttachments.test.ts` is excluded by `!**/*.test.*`, `!**/__tests__/**` and included by `lib/**` * `lib/agents/content/__tests__/registerOnNewMention.test.ts` is excluded by `!**/*.test.*`, `!**/__tests__/**` and included by `lib/**`

📒 Files selected for processing (2)

* `lib/agents/content/extractMessageAttachments.ts` * `lib/agents/content/handlers/registerOnNewMention.ts`