🧹 Nitpick comments (3)

app/api/accounts/emails/route.ts (2)
`16-28`: **Add `@param` and `@returns` to GET handler JSDoc.** The static analysis correctly identifies missing JSDoc declarations. Completing these improves API documentation consistency.

📝 Proposed JSDoc fix
```diff /** * GET /api/accounts/emails * * Retrieves account email rows for the requested account IDs after verifying * that the authenticated caller has access to the provided artist account. * * Query parameters: * - artist_account_id (required): Artist account used for access checks * - account_id (optional, repeatable): Account IDs to look up + * + * `@param` request - The incoming Next.js request object + * `@returns` NextResponse with account emails array or error */ export async function GET(request: NextRequest) { ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@app/api/accounts/emails/route.ts` around lines 16 - 28, The JSDoc block above the exported GET handler is missing `@param` and `@returns` tags; update the comment for the GET function (which delegates to getAccountEmailsHandler) to include a `@param` {NextRequest} request describing the request and a `@returns` {Promise} describing the returned response so static analysis and generated docs include the parameter and return types/semantics. ```
--- `6-14`: **Complete JSDoc with `@returns` declaration.** Static analysis flags the missing `@returns` documentation. For API routes, documenting the response helps maintain consistency.

📝 Proposed JSDoc fix
```diff /** * OPTIONS handler for CORS preflight requests. + * `@returns` NextResponse with 200 status and CORS headers */ export async function OPTIONS() { ```

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@app/api/accounts/emails/route.ts` around lines 6 - 14, The JSDoc for the OPTIONS handler (exported function OPTIONS) is missing a `@returns` tag; update its block comment to include a `@returns` that describes the NextResponse returned (status 200 with CORS headers) so static analysis is satisfied. Ensure the `@returns` mentions the NextResponse object and the fact it returns a 200 response for CORS preflight with headers from getCorsHeaders(), and keep the description concise and consistent with the existing comment. ```

lib/accounts/validateGetAccountEmailsQuery.ts (1)
`6-10`: **Consider using Zod for query parameter validation.** Per coding guidelines, validate functions should use Zod for schema validation and export both the schema and inferred TypeScript type. The current implementation uses manual validation which works correctly, but adopting Zod would: 1. Provide declarative, self-documenting validation rules 2. Enable automatic type inference from the schema 3. Maintain consistency with other validate functions in the codebase

♻️ Proposed Zod-based implementation
```diff import type { NextRequest } from "next/server"; import { NextResponse } from "next/server"; import { getCorsHeaders } from "@/lib/networking/getCorsHeaders"; import { validateAuthContext } from "@/lib/auth/validateAuthContext"; +import { z } from "zod"; -export interface ValidatedGetAccountEmailsQuery { - authenticatedAccountId: string; - artistAccountId: string; - accountIds: string[]; -} +export const getAccountEmailsQuerySchema = z.object({ + artist_account_id: z.string().min(1, "artist_account_id parameter is required"), + account_id: z.array(z.string()).optional().default([]), +}); + +export type ValidatedGetAccountEmailsQuery = z.infer & { + authenticatedAccountId: string; +}; /** * Validates auth and query params for GET /api/accounts/emails. */ export async function validateGetAccountEmailsQuery( request: NextRequest, ): Promise { const authResult = await validateAuthContext(request); if (authResult instanceof NextResponse) { return authResult; } const { searchParams } = new URL(request.url); - const artistAccountId = searchParams.get("artist_account_id"); - - if (!artistAccountId) { - return NextResponse.json( - { error: "artist_account_id parameter is required" }, - { - status: 400, - headers: getCorsHeaders(), - }, - ); - } - - return { - authenticatedAccountId: authResult.accountId, - artistAccountId, - accountIds: searchParams.getAll("account_id"), - }; + const parseResult = getAccountEmailsQuerySchema.safeParse({ + artist_account_id: searchParams.get("artist_account_id"), + account_id: searchParams.getAll("account_id"), + }); + + if (!parseResult.success) { + return NextResponse.json( + { error: parseResult.error.issues[0]?.message ?? "Invalid query parameters" }, + { status: 400, headers: getCorsHeaders() }, + ); + } + + return { + authenticatedAccountId: authResult.accountId, + artistAccountId: parseResult.data.artist_account_id, + accountIds: parseResult.data.account_id, + }; } ```
As per coding guidelines: "For validation functions, ensure: Use Zod for schema validation, Return NextResponse on error or validated data on success, Export inferred types for validated data." Also applies to: 23-40

🤖 Prompt for AI Agents
``` Verify each finding against the current code and only fix it if needed. In `@lib/accounts/validateGetAccountEmailsQuery.ts` around lines 6 - 10, The current manual validation that yields the ValidatedGetAccountEmailsQuery shape should be replaced with a Zod schema: define and export a zod schema (e.g., getAccountEmailsQuerySchema) that enforces authenticatedAccountId and artistAccountId as strings and accountIds as string array, export the inferred TypeScript type (e.g., type ValidatedGetAccountEmailsQuery = z.infer), and update the validate function to parse the incoming query with schema.safeParse or try/catch and return a NextResponse on validation error or the validated data on success; update any references to use the new schema and exported inferred type. ```

🤖 Prompt for all review comments with AI agents

``` Verify each finding against the current code and only fix it if needed. Nitpick comments: In `@app/api/accounts/emails/route.ts`: - Around line 16-28: The JSDoc block above the exported GET handler is missing `@param` and `@returns` tags; update the comment for the GET function (which delegates to getAccountEmailsHandler) to include a `@param` {NextRequest} request describing the request and a `@returns` {Promise} describing the returned response so static analysis and generated docs include the parameter and return types/semantics. - Around line 6-14: The JSDoc for the OPTIONS handler (exported function OPTIONS) is missing a `@returns` tag; update its block comment to include a `@returns` that describes the NextResponse returned (status 200 with CORS headers) so static analysis is satisfied. Ensure the `@returns` mentions the NextResponse object and the fact it returns a 200 response for CORS preflight with headers from getCorsHeaders(), and keep the description concise and consistent with the existing comment. In `@lib/accounts/validateGetAccountEmailsQuery.ts`: - Around line 6-10: The current manual validation that yields the ValidatedGetAccountEmailsQuery shape should be replaced with a Zod schema: define and export a zod schema (e.g., getAccountEmailsQuerySchema) that enforces authenticatedAccountId and artistAccountId as strings and accountIds as string array, export the inferred TypeScript type (e.g., type ValidatedGetAccountEmailsQuery = z.infer), and update the validate function to parse the incoming query with schema.safeParse or try/catch and return a NextResponse on validation error or the validated data on success; update any references to use the new schema and exported inferred type. ```

---

ℹ️ Review info

⚙️ Run configuration

**Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro **Run ID**: `9043f468-02ba-41b7-837f-be4b2804b354`

📥 Commits

Reviewing files that changed from the base of the PR and between a3eec5deb69989ffc357f6ddcf8e1402e8f0f420 and f28ad17e44e2e2235e6800f496901ba5139201cb.

⛔ Files ignored due to path filters (2)

* `lib/accounts/__tests__/getAccountEmailsHandler.test.ts` is excluded by `!**/*.test.*`, `!**/__tests__/**` and included by `lib/**` * `lib/accounts/__tests__/validateGetAccountEmailsQuery.test.ts` is excluded by `!**/*.test.*`, `!**/__tests__/**` and included by `lib/**`

📒 Files selected for processing (4)

* `app/api/accounts/emails/route.ts` * `lib/accounts/getAccountEmailsHandler.ts` * `lib/accounts/validateGetAccountEmailsQuery.ts` * `lib/supabase/account_emails/selectAccountEmails.ts`