chore(msrv): lower rust-version to measured 1.88.0 floor (RM-2465)

RM
5h ago
+97-58

User description

Summary

  • Cargo.toml rust-version lowered from 1.97.1 → 1.88.0, the measured floor per the stack-wide MSRV policy in Limen-Neural/neuromod#214.
  • Verified locally: cargo +1.85 check --all-targets --all-features fails on let-chains (1.88) plus unsigned_is_multiple_of/slice_as_chunks; cargo +1.88.0 check, clippy -D warnings, fmt --check, build, and test --all-features all pass.
  • The CI msrv job no longer hardcodes 1.97.1 — it reads package.rust-version from Cargo.toml and sets RUSTUP_TOOLCHAIN per step so the rust-toolchain.toml 1.99.0 pin does not leak in.
  • Dev toolchain unchanged: rust-toolchain.toml and the quality/test/coverage/release jobs stay on 1.99.0 (rust-version <= toolchain channel).
  • REVIEW.md pin rule rewritten for the split; README badge/MSRV section, RELEASE.md, AGENTS.md, CLAUDE.md, and CHANGELOG.md updated.

Closes #137
Refs Limen-Neural/neuromod#214

Test plan

  • cargo +1.88.0 fmt --check / clippy --all-targets --all-features -D warnings / test --all-features — pass
  • cargo +1.85 check --all-targets --all-features — fails as expected (confirms floor)
  • cargo fmt --check, cargo clippy (default + all features), cargo test --all-features on pinned 1.99.0 — pass
  • CI msrv job green on 1.88.0

Generated with Devin

Summary by Sourcery

Lower the crate’s MSRV to the measured Rust 1.88.0 floor and make CI and project documentation track it independently from the Rust 1.99.0 development toolchain.

Enhancements:

  • Lower the declared minimum supported Rust version to 1.88.0 while keeping the development toolchain pinned at 1.99.0.
  • Make the MSRV CI job derive its toolchain from Cargo.toml and validate formatting, checks, linting, builds, and tests against it.

CI:

  • Decouple MSRV validation from the pinned development toolchain and hardcoded workflow version.

Documentation:

  • Update repository guidance, release instructions, review procedures, changelog, and MSRV documentation for the new version split.

Summary by cubic

Lowers the declared MSRV from 1.97.1 to 1.88.0, the measured floor where cargo check --all-targets --all-features passes. The dev toolchain stays pinned at 1.99.0, so the two pins are now decoupled; the crate's advertised minimum no longer tracks "then-current stable."

CI

  • The msrv job now reads package.rust-version from Cargo.toml instead of a hardcoded toolchain, adds a cargo check --all-features --locked step, and sets RUSTUP_TOOLCHAIN per step so the 1.99.0 pin doesn't leak in.
  • Non-MSRV jobs (quality, test, coverage, release) remain on 1.99.0.

Docs

  • README.md, REVIEW.md, RELEASE.md, AGENTS.md, CLAUDE.md, .coderabbit.yaml, .agents/setup, and CHANGELOG.md updated for the new MSRV and the rule that the two pins are changed independently.

Closes #137.

Written for commit f862cabf9332b5ccb04d55cf5110628c77780c1f. Summary will update on new commits.

View guided diff Turn on auto-fix

CodeAnt-AI Description

Lower the minimum supported Rust version to 1.88.0

What Changed

  • Consumers can now build the crate with Rust 1.88.0 instead of Rust 1.97.1.
  • The MSRV CI job reads the minimum version from Cargo.toml and checks formatting, linting, builds, and tests against it.
  • The development toolchain remains pinned to Rust 1.99.0.

Impact

✅ Build with Rust 1.88.0
✅ MSRV checks follow the declared minimum

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Summary by CodeRabbit

  • Changed
    • The minimum supported Rust version is now 1.88.0, down from 1.97.1.
  • Documentation
    • Updated project guidance and release information to reflect the new minimum supported version and distinguish it from the Rust 1.99.0 development toolchain.
    • CI now determines the minimum-version checks from the version declared by the project, rather than a hard-coded value.