fix(ci): resolve shellcheck/treefmt failures

Merged
SH
5mo ago
+8-2

Summary

Fixes the failing GitHub Actions on main (Shell + Nix checks) and adds missing brew CLIs.

Failing GitHub Actions fixed

  • Shell / shell-lint was red: ShellCheck flagged SC2018/SC2019 in spec/npm_globals_spec.sh:251 (tr 'A-Z' 'a-z'), and since CI runs at default severity the info finding exited non-zero (xargs 123). Switched to POSIX classes tr '[:upper:]' '[:lower:]'.
  • Nix / nix-format (and downstream nix-flake / nix-test via treefmt check) was red: the same spec file was not shfmt-formatted. Applied the formatting treefmt --fail-on-change requires.

Both verified locally:

  • shellcheck spec/npm_globals_spec.sh -> clean
  • nix fmt -- --fail-on-change -> 0 changed

Brew CLIs added (nix-darwin/config/homebrew.nix)

  • stripe-cli (Stripe CLI; stripe is the homebrew/core alias, so no extra tap needed) - run stripe login after install
  • grafana
  • loki
  • argo

Summary by cubic

Fixes failing CI checks (ShellCheck and Nix/treefmt) and adds missing Homebrew CLIs. Pipeline is green again and devs get stripe-cli, grafana, loki, and argo.

  • Bug Fixes

    • Replaced tr 'A-Z' 'a-z' with tr '[:upper:]' '[:lower:]' to satisfy ShellCheck SC2018/SC2019 in spec/npm_globals_spec.sh.
    • Applied shfmt so treefmt/Nix format checks pass.

  • Dependencies

    • Added brews in nix-darwin/config/homebrew.nix: stripe-cli, grafana, loki, argo.