chore(lint): delete unused variables and parameters; enforce both rules repo-wide

Merged
WA
1mo ago
+1001-4888

Summary

  • Delete every unused variable and function parameter across apps (~495 variables, ~167 parameters), ~230 dead private interfaces/types, unused loggers, and catch (e) bindings → catch {}
  • Remove the unused BlockConfig<T> type parameter (it never appeared in the interface body); blocks now write plain BlockConfig as the skills already say
  • Enforce noUnusedVariables and noUnusedFunctionParameters as errors repo-wide with fix: "none" so bun run lint's unsafe autofix can't silently _-prefix bindings; ignoreRestSiblings keeps the const { a, ...rest } omit idiom. Redundant packages/** override removed
  • _ prefixes remain only on parameters that must hold their position (route handlers using a later arg, connector/tool callbacks); no biome-ignore
  • Side-effecting calls kept with the binding dropped (e.g. draining a Teams response body to release the connection, an authorization execute whose result was unused)
  • CLAUDE.md gets the matching rule; CONTRIBUTING's block example updated

Type of Change

  • Chore / refactor (no intended behavior change)

Testing

  • bun run lint, bunx turbo run type-check, bun run check:audits, root bun run test (test:scripts + every workspace suite)
  • Three independent audits re-checked every removed parameter's callers repo-wide (no positional shifts), every dropped initializer for side effects, and test tables; 264 of 384 block/tool files transpile to byte-identical JS (type-only changes)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

šŸ¤– Generated with Claude Code