ci(buildkite): render steps from the wave-ci custom template

YA
13d ago
+203-66

User description

Pilot for wave-ci#212: the cli pipeline moves from hand-written YAML to the wave-ci custom template. Merges after #93 (which provides the top-level upload.sh the Steps setting runs); the Steps setting itself never changes.

What changes (5 files):

  • .buildkite/pipeline.yml becomes the thin uploader (render + caps-lint + upload)
  • .buildkite/wave-ci.json is new: the 4 steps (same keys/labels/scripts/timeouts), governance-enforce keeps NODE_AUTH_TOKEN, pin a96f425
  • .buildkite/wave-ci.sh is new: the fixed shim, mode 100755, unedited
  • scripts/lib/common.sh absorbs the old top-level env (CI=true, NPM_CONFIG_AUDIT/FUND/UPDATE_NOTIFIER=false) since the template emits no env
  • README.md notes the render source

Proof (all local, zero venue dependency):

  • wave-ci-onboard validate: manifest clean; onboard plan caps-lint 0 errors 0 warnings
  • render with the pinned wave-ci code: exit 0; governance-enforce routes to fpc-isolated-secrets, the other 3 stay fpc-isolated; labels/timeouts/keys byte-identical to the live steps
  • rendered YAML caps-lint: 0 errors 0 warnings
  • pin a96f425 is newest image-proven (wave-pricing build 38 render step passed on it 2026-10-21), NOT the manifest default f33e7af (3 weeks stale; pin move rides the companion wave-ci PR)

Known diffs vs the live steps (all intended): governance-enforce moves to the secrets queue; retry modernizes exit-255 to signal agent_stop; manual-retry defaults made explicit.

Blockers to green (tracked, not in this PR): ci-smoke TSV row cli/governance-enforce/NODE_AUTH_TOKEN + host install (companion PR); build 1 showed all 4 steps failing exit 1 in ~2s on finemanpc-s02, which smells environmental (see my comment on #93) - the first build of this branch will confirm or deny.

Summary by CodeRabbit

  • Chores
    • Updated the CI pipeline to render and upload its steps from a shared configuration. The configured checks include unit tests, package-install smoke tests, and offline license checks.
    • Standardized CI settings, including the Node.js version and npm notification and audit options.
  • Documentation
    • Clarified how pipeline steps are configured and which checks are currently parked.

CodeAnt-AI Description

Generate CLI Buildkite checks from a pinned wave-ci template

What Changed

  • Buildkite now renders its pipeline from the pinned wave-ci template, keeping the unit, smoke, and license checks.
  • The governance-enforce check is no longer run for the public CLI repository, where its required secret is unavailable.
  • Buildkite jobs now use Node 22 to match the version expected by the checks.

Impact

✅ Fewer Node-version failures in Buildkite
✅ Unit, smoke, and license checks remain active
✅ No blocked governance-enforce job in public-repository builds

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.